ReactNative-application.cmake links autolinked libraries to common_flags with the plain target_link_libraries signature, so a library that uses PRIVATE fails the app's CMake configure

Aperta Adatta ai principianti
  • Qualcosa non va?
#60,000 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
70/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cmake, react-native
Ambito
build-system

Direzione di ricerca

Apri ReactAndroid/cmake-utils/ReactNative-application.cmake e trova il blocco foreach(autolinked_library ...) intorno alla riga 97 (0.88.1) / 108 (nightly), insieme al collegamento ${APP_CODEGEN_TARGET} subito sotto. Entrambi usano la forma semplice target_link_libraries, che è in conflitto con le librerie che si collegano da sole tramite PRIVATE/PUBLIC. Leggi modules/keyword-linking/android/CMakeLists.txt nel repository del reproducer per vedere la combinazione che fallisce, poi esegui ./reproduce.sh nel reproducer per confermare l'errore di configurazione prima di modificare. Il lavoro è completato quando il ciclo usa una firma con keyword in modo coerente e ./gradlew :app:configureCMakeDebug[arm64-v8a] termina con exit 0, mentre una libreria che non collega nulla o collega in modo semplice continua a configurarsi.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Needs: Triage :mag:
Description

ReactNative-application.cmake links every autolinked library to common_flags with the plain signature:

foreach(autolinked_library ${AUTOLINKED_LIBRARIES})
    target_link_libraries(${autolinked_library} common_flags)
endforeach()

CMake refuses to mix the plain and the keyword signatures on one target, so an autolinked library whose own CMakeLists.txt links its target with PRIVATE, PUBLIC or INTERFACE fails the configure of every app that installs it. The app-level codegen target is linked the same way (target_link_libraries(${APP_CODEGEN_TARGET} common_flags)).

Steps to reproduce

  1. Clone the reproducer and run ./reproduce.sh (react-native 0.88.1) or ./reproduce.sh nightly. ReproducerApp depends on a local library, modules/keyword-linking, whose react-native.config.js gives Android libraryName: 'keywordlinking' and cmakeListsPath: 'CMakeLists.txt', and whose android/CMakeLists.txt is:

    add_library(react_codegen_keywordlinking SHARED keyword-linking.cpp)
target_link_libraries(react_codegen_keywordlinking PRIVATE fbjni jsi reactnative)

  2. The script runs npm install, then ./gradlew :app:configureCMakeDebug[arm64-v8a] -PreactNativeArchitectures=arm64-v8a in ReproducerApp/android.

Expected: the app's CMake build configures, as it does when the library drops PRIVATE.

Seen: the configure fails at ReactNative-application.cmake:97 on 0.88.1 and at :108 on 0.90.0-nightly-20261113-6d587e873. The script exits 1 while this shows and 0 once the configure passes.

React Native Version

0.88.1

Affected Platforms

Runtime - Android, Build - Windows

Output of npx @react-native-community/cli info
System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
Binaries:
  Node:
    version: 26.12.1
  npm:
    version: 12.2.1
Languages:
  Java:
    version: 17.0.20.1
npmPackages:
  "@react-native-community/cli":
    installed: 20.2.0
    wanted: 20.2.0
  react:
    installed: 19.3.0
    wanted: 19.3.0
  react-native:
    installed: 0.88.1
    wanted: 0.88.1
Android:
  hermesEnabled: true
  newArchEnabled: true
Stacktrace or Logs
react-native 0.90.0-nightly-20261113-6d587e873
$ ./gradlew :app:configureCMakeDebug[arm64-v8a] -PreactNativeArchitectures=arm64-v8a
gradle exit 1
C/C++: CMake Error at ReproducerApp/node_modules/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake:108 (target_link_libraries):
C/C++:   The keyword signature for target_link_libraries has already been used with
C/C++:   the target "react_codegen_keywordlinking".  All uses of
C/C++:   target_link_libraries with a target must be either all-keyword or
C/C++:   all-plain.
C/C++:   The uses of the keyword signature are here:
C/C++:    * ReproducerApp/node_modules/keyword-linking/android/CMakeLists.txt:7 (target_link_libraries)
C/C++: Call Stack (most recent call first):
C/C++:   CMakeLists.txt:31 (include)
SUMMARY: defect: the app's CMake configure fails, as ReactNative-application.cmake links react_codegen_keywordlinking with the plain signature and its own CMakeLists uses PRIVATE (react-native 0.90.0-nightly-20261113-6d587e873)
MANDATORY Reproducer

https://github.com/YevheniiKotyrlo/react-native-autolinked-keyword-link-signature

Screenshots and Videos

No response

Lingua principale
C++
Stelle
127k
Fork
25.5k
Merge medio
4g 47m
PR unite (30g)
217

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di react/react-native

Tutte le issue di react/react-native

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.