C++ API snapshots: `ReactCommon` and `ReactAndroid` read the tvOS view headers, as `scripts/cxx-api/config.yml` does not exclude `*/platform/tvos/*`
Maintainer antworten meist innerhalb von 2 Tagen
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Anfängerfreundlichkeit
- 72/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- bash, cpp, yaml
- Bereich
- build-system, mobile-dev
Rechercherichtung
Lies zuerst die exclude_patterns für ReactCommon, ReactAndroid und ReactApple in scripts/cxx-api/config.yml und vergleiche sie dann mit den im Issue beschriebenen Plattformpfaden. Der Reproducer prüft die Ausschlüsse und die eingecheckten API-Snapshots; führe bash repro.sh in einem Checkout aus, um das aktuelle Ergebnis zu bestätigen. Das Ziel ist erreicht, wenn ReactCommon und ReactAndroid tvOS-Header ausschließen und die betroffenen Snapshots die tvOS-Klasse nicht mehr enthalten, während die Ausschlüsse für die anderen Plattformen unverändert bleiben.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Description
scripts/cxx-api/config.yml leaves each view platform folder out of the snapshots that are not for it: ReactCommon excludes */platform/cxx/*, windows, macos, ios and android (L27-L33), and ReactAndroid excludes cxx, windows, macos and ios (L58-L65). Neither names */platform/tvos/*, so both read ReactCommon/react/renderer/components/view/platform/tvos/:
- all four
ReactCommon*Cxx.apilistclass facebook::react::HostPlatformViewPropswithpublic bool focusable;, which only the tvOS header declares (L28); - each
ReactAndroid*Cxx.apimerges the tvOSHostPlatformViewPropsinto Android's. Onmainboth declarebool focusable{false};, so it does not show; https://github.com/react/react-native/pull/59048 makes Android'sstd::optional<bool> focusable{}, and its regeneratedReactAndroidDebugCxx.apilists bothpublic bool focusable;andpublic std::optional<bool> focusable;in the one class.
ReactApple does not exclude */platform/tvos/* either, and it does exclude */platform/cxx/*, the folder React-Fabric.podspec compiles for iOS (L168), so ReactAppleDebugCxx.api lists the tvOS class where iOS has using HostPlatformViewProps = BaseViewProps;.
Steps to reproduce
- Run
bash repro.shfrom the reproducer below. It sparse-clonesmain, matches each view platform'sHostPlatformViewProps.hagainst each snapshot'sexclude_patternsinscripts/cxx-api/config.yml(with the template's*/tests/*and*/samples/*), and prints theHostPlatformViewPropsclass of the committedReactCommon*Cxx.apiandReactAndroidDebugCxx.api.bash repro.sh <path to a react-native checkout>reads a checkout instead.
Expected: ReactCommon and ReactAndroid read nothing under platform/tvos, so no ReactCommon*Cxx.api lists a HostPlatformViewProps class and the ReactAndroid*Cxx.api class holds Android's members only; their other platform exclusions stay as they are.
Actual: both read platform/tvos/.../HostPlatformViewProps.h, and all four ReactCommon*Cxx.api list the tvOS class with public bool focusable; (log below).
React Native Version
main at bbfd391496 (nightly)
Affected Platforms
Other (please specify): the C++ API snapshots in scripts/cxx-api
Output of npx @react-native-community/cli info
Not applicable: this is the configuration of React Native's own C++ API snapshots. The reproducer's run:
react-native bbfd391 (2026-11-19), MINGW64_NT-10.0-26300 3.6.10-5a1665c8.x86_64, bash 5.3.15(2)-release
Stacktrace or Logs
react-native bbfd391 (2026-11-19), MINGW64_NT-10.0-26300 3.6.10-5a1665c8.x86_64, bash 5.3.15(2)-release
platform/android/.../HostPlatformViewProps.h:44: bool focusable{false};
platform/cxx/.../HostPlatformViewProps.h:15:using HostPlatformViewProps = BaseViewProps;
platform/tvos/.../HostPlatformViewProps.h:28: bool focusable{false};
config.yml ReactCommon exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/ios/* */platform/android/*
ReactCommon reads HostPlatformViewProps.h from: platform/tvos
config.yml ReactAndroid exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/ios/*
ReactAndroid reads HostPlatformViewProps.h from: platform/android platform/tvos
config.yml ReactApple exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/android/*
ReactApple reads HostPlatformViewProps.h from: platform/tvos
ReactCommonDebugCxx.api:
676: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
679: public bool focusable;
ReactCommonFrameworksCxx.api:
1238: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
1241: public bool focusable;
ReactCommonNewarchCxx.api:
675: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
678: public bool focusable;
ReactCommonReleaseCxx.api:
675: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
678: public bool focusable;
ReactAndroidDebugCxx.api:
1329: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
1333: public bool focusable;
SUMMARY: snapshots whose exclude_patterns let them read platform/tvos/.../HostPlatformViewProps.h: ReactCommon ReactAndroid; committed ReactCommon snapshots with class facebook::react::HostPlatformViewProps: ReactCommonDebug ReactCommonFrameworks ReactCommonNewarch ReactCommonRelease
MANDATORY Reproducer
https://gist.github.com/YevheniiKotyrlo/d19e454d6ff5635c01ac24ce902e513e — bash repro.sh exits 1 while ReactCommon or ReactAndroid reads platform/tvos or a committed ReactCommon*Cxx.api lists class facebook::react::HostPlatformViewProps, and 0 once neither holds.
Screenshots and Videos
No response
- Vorherrschende Sprache
- C++
- Sterne
- 127k
- Forks
- 25.5k
- Ø Merge
- 3 T. 17 Std.
- Gemergte PRs (30 T.)
- 302
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus react/react-native
-
Needs: Triage :mag: Platform: Android
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
react/react-native#60177 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Android: with view recycling on, a recycled View keeps its nextFocusLeftEvtl. vergeben @lazerg hat das heute übernommen. OffenNeeds: Triage :mag: Platform: Android
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
react/react-native#60167 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Needs: Author Feedback Needs: Repro
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
react/react-native#60091 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Needs: Triage :mag:
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
react/react-native#60000 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deletedEvtl. vergeben @lazerg hat das vor 8 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
react/react-native#59939 ·
Maintainer antworten meist innerhalb von 2 Tagen
Alle Issues in react/react-native
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 79/100
tenstorrent/tt-umd#4017 ·
Maintainer antworten meist innerhalb von 3 Tagen
-
difficulty:easy func:gui prio:low type:bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
NatronGitHub/Natron#1538 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
hyprwm/hyprsunset#103 · 1 Kommentar ·
-
Feature request
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
qbittorrent/qBittorrent#25338 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 77/100
Maintainer antworten meist innerhalb von 1 Tag