C++ API snapshots: `ReactCommon` and `ReactAndroid` read the tvOS view headers, as `scripts/cxx-api/config.yml` does not exclude `*/platform/tvos/*`
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 72/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- bash, cpp, yaml
调研方向
首先阅读 scripts/cxx-api/config.yml 中 ReactCommon、ReactAndroid 和 ReactApple 的 exclude_patterns,然后将它们与 issue 中描述的平台路径进行比较。复现脚本会检查排除项和已提交的 API 快照;在一个 checkout 中运行 bash repro.sh,以确认当前结果。当 ReactCommon 和 ReactAndroid 排除 tvOS 头文件,受影响的快照不再包含 tvOS 类,同时其他平台的排除项保持不变时,任务即告完成。
由索引模型根据 Issue 内容生成。
描述
Description
scripts/cxx-api/config.yml leaves each view platform folder out of the snapshots that are not for it: ReactCommon excludes */platform/cxx/*, windows, macos, ios and android (L27-L33), and ReactAndroid excludes cxx, windows, macos and ios (L58-L65). Neither names */platform/tvos/*, so both read ReactCommon/react/renderer/components/view/platform/tvos/:
- all four
ReactCommon*Cxx.apilistclass facebook::react::HostPlatformViewPropswithpublic bool focusable;, which only the tvOS header declares (L28); - each
ReactAndroid*Cxx.apimerges the tvOSHostPlatformViewPropsinto Android's. Onmainboth declarebool focusable{false};, so it does not show; https://github.com/react/react-native/pull/59048 makes Android'sstd::optional<bool> focusable{}, and its regeneratedReactAndroidDebugCxx.apilists bothpublic bool focusable;andpublic std::optional<bool> focusable;in the one class.
ReactApple does not exclude */platform/tvos/* either, and it does exclude */platform/cxx/*, the folder React-Fabric.podspec compiles for iOS (L168), so ReactAppleDebugCxx.api lists the tvOS class where iOS has using HostPlatformViewProps = BaseViewProps;.
Steps to reproduce
- Run
bash repro.shfrom the reproducer below. It sparse-clonesmain, matches each view platform'sHostPlatformViewProps.hagainst each snapshot'sexclude_patternsinscripts/cxx-api/config.yml(with the template's*/tests/*and*/samples/*), and prints theHostPlatformViewPropsclass of the committedReactCommon*Cxx.apiandReactAndroidDebugCxx.api.bash repro.sh <path to a react-native checkout>reads a checkout instead.
Expected: ReactCommon and ReactAndroid read nothing under platform/tvos, so no ReactCommon*Cxx.api lists a HostPlatformViewProps class and the ReactAndroid*Cxx.api class holds Android's members only; their other platform exclusions stay as they are.
Actual: both read platform/tvos/.../HostPlatformViewProps.h, and all four ReactCommon*Cxx.api list the tvOS class with public bool focusable; (log below).
React Native Version
main at bbfd391496 (nightly)
Affected Platforms
Other (please specify): the C++ API snapshots in scripts/cxx-api
Output of npx @react-native-community/cli info
Not applicable: this is the configuration of React Native's own C++ API snapshots. The reproducer's run:
react-native bbfd391 (2026-11-19), MINGW64_NT-10.0-26300 3.6.10-5a1665c8.x86_64, bash 5.3.15(2)-release
Stacktrace or Logs
react-native bbfd391 (2026-11-19), MINGW64_NT-10.0-26300 3.6.10-5a1665c8.x86_64, bash 5.3.15(2)-release
platform/android/.../HostPlatformViewProps.h:44: bool focusable{false};
platform/cxx/.../HostPlatformViewProps.h:15:using HostPlatformViewProps = BaseViewProps;
platform/tvos/.../HostPlatformViewProps.h:28: bool focusable{false};
config.yml ReactCommon exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/ios/* */platform/android/*
ReactCommon reads HostPlatformViewProps.h from: platform/tvos
config.yml ReactAndroid exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/ios/*
ReactAndroid reads HostPlatformViewProps.h from: platform/android platform/tvos
config.yml ReactApple exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/android/*
ReactApple reads HostPlatformViewProps.h from: platform/tvos
ReactCommonDebugCxx.api:
676: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
679: public bool focusable;
ReactCommonFrameworksCxx.api:
1238: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
1241: public bool focusable;
ReactCommonNewarchCxx.api:
675: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
678: public bool focusable;
ReactCommonReleaseCxx.api:
675: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
678: public bool focusable;
ReactAndroidDebugCxx.api:
1329: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
1333: public bool focusable;
SUMMARY: snapshots whose exclude_patterns let them read platform/tvos/.../HostPlatformViewProps.h: ReactCommon ReactAndroid; committed ReactCommon snapshots with class facebook::react::HostPlatformViewProps: ReactCommonDebug ReactCommonFrameworks ReactCommonNewarch ReactCommonRelease
MANDATORY Reproducer
https://gist.github.com/YevheniiKotyrlo/d19e454d6ff5635c01ac24ce902e513e — bash repro.sh exits 1 while ReactCommon or ReactAndroid reads platform/tvos or a committed ReactCommon*Cxx.api lists class facebook::react::HostPlatformViewProps, and 0 once neither holds.
Screenshots and Videos
No response
- 主要语言
- C++
- 星标
- 127k
- 派生
- 25.5k
- 平均合并
- 3 天 17 小时
- 30 天内合并 PR
- 302
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
react/react-native 的其他 Issue
-
Needs: Triage :mag: Platform: Android
难度 2/5 1-3 小时 新手友好度 78/100
react/react-native#60177 ·
维护者通常 2 天内回复
-
Android: with view recycling on, a recycled View keeps its nextFocusLeft可能已有人在做 @lazerg 今天认领。 未关闭Needs: Triage :mag: Platform: Android
难度 2/5 1-3 小时 新手友好度 78/100
react/react-native#60167 ·
维护者通常 2 天内回复
-
Needs: Author Feedback Needs: Repro
难度 2/5 1-3 小时 新手友好度 74/100
react/react-native#60091 · 1 条评论 ·
维护者通常 2 天内回复
-
Needs: Triage :mag:
难度 2/5 1-3 小时 新手友好度 70/100
react/react-native#60000 ·
维护者通常 2 天内回复
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deleted可能已有人在做 @lazerg 于 8 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
react/react-native#59939 ·
维护者通常 2 天内回复
查看 react/react-native 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 79/100
tenstorrent/tt-umd#4017 ·
维护者通常 3 天内回复
-
difficulty:easy func:gui prio:low type:bug
难度 2/5 1-3 小时 新手友好度 72/100
NatronGitHub/Natron#1538 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
hyprwm/hyprsunset#103 · 1 条评论 ·
-
Feature request
难度 2/5 1-3 小时 新手友好度 65/100
qbittorrent/qBittorrent#25338 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复