Filters on game objects are misplaced when the camera is zoomed and its origin isn't 0.5

Aperta
#7,402 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
62/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
frontend, game-dev

Direzione di ricerca

Start in src/gameobjects/components/Filters.js at the filter camera setup described in the suggested patch, then trace how the filter camera copies the main camera’s scroll, rotation, and zoom. Reproduce the reported case with zoom 2 and origin (0, 0), including a filtered object and a mask. Done when filtered objects and masks render in the correct position with non-default camera origins and zoom, while the reported working cases still work.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

When a camera has a zoom other than 1 and an origin other than the default 0.5 (e.g. setOrigin(0, 0)), game objects with filters render in the wrong place, usually off screen. This applies to internal and external filters, and to masks as well as other filters. Without filters, the same objects render correctly. It also works correctly at zoom 1, or with the default camera origin.

Version

  • Phaser Version:

Phaser 4.2.1, WebGL

  • Operating system:
    Linux (CachyOS)

  • Browser:
    Chrome

Description

Example Test Code

class S extends Phaser.Scene {
    create() {
        const cam = this.cameras.main.setZoom(2).setOrigin(0, 0)
        this.input.on('pointerdown', () => this.tweens.add({ targets: cam, zoom: cam.zoom > 1.5 ? 1 : 2, duration: 1000 }))
        this.add.rectangle(20, 20, 80, 60, 0x3399ff).setOrigin(0, 0)
        const filtered = this.add.rectangle(120, 20, 80, 60, 0x3399ff).setOrigin(0, 0)
        filtered.enableFilters().filters.internal.addColorMatrix().colorMatrix.grayscale()
        this.add.text(20, 90, 'Click to toggle the zoom', { fontSize: '10px' })
    }
}
new Phaser.Game({ type: Phaser.WEBGL, width: 800, height: 400, scene: S })

Additional Information

Suggested patch by claude which fixes it on my side bellow. Not knowledgable enough about Phaser internals to be confident it's the proper fix.

diff --git a/dist/phaser.esm.js b/dist/phaser.esm.js
index 8c6521ac895c8ba041b6990573cdb38e7210fec6..943448f360e4408348a5c243d965b645843cd2fb 100644
--- a/dist/phaser.esm.js
+++ b/dist/phaser.esm.js
@@ -47759,6 +47759,8 @@ if (true)
             this.filterCamera.setScroll(posX, posY);
             this.filterCamera.setRotation(rotation);
             this.filterCamera.setZoom(zoomX, zoomY);
+            this.filterCamera.setOrigin(camera.originX, camera.originY);
 
             return this;
         },
diff --git a/dist/phaser.js b/dist/phaser.js
index d5f7d60dd067d6a5b9d1fc2518b216f821f16e0c..0c53f1180482fb08a1e930fe08fc9db5164ef1db 100644
--- a/dist/phaser.js
+++ b/dist/phaser.js
@@ -47771,6 +47771,8 @@ if (true)
             this.filterCamera.setScroll(posX, posY);
             this.filterCamera.setRotation(rotation);
             this.filterCamera.setZoom(zoomX, zoomY);
+            this.filterCamera.setOrigin(camera.originX, camera.originY);
 
             return this;
         },
diff --git a/src/gameobjects/components/Filters.js b/src/gameobjects/components/Filters.js
index ba66b79e12b686cdb3d7244dfcd2dd59389c3432..358c408247319d9448d2be243d9f839f951bad8a 100644
--- a/src/gameobjects/components/Filters.js
+++ b/src/gameobjects/components/Filters.js
@@ -549,6 +549,8 @@ if (typeof WEBGL_RENDERER)
             this.filterCamera.setScroll(posX, posY);
             this.filterCamera.setRotation(rotation);
             this.filterCamera.setZoom(zoomX, zoomY);
+            this.filterCamera.setOrigin(camera.originX, camera.originY);
 
             return this;
         },
Lingua principale
JavaScript
Stelle
40.7k
Fork
7.2k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di phaserjs/phaser

Tutte le issue di phaserjs/phaser

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.