Filters on game objects are misplaced when the camera is zoomed and its origin isn't 0.5

Abierto
#7,402 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
62/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript

Línea de trabajo

Start in src/gameobjects/components/Filters.js at the filter camera setup described in the suggested patch, then trace how the filter camera copies the main camera’s scroll, rotation, and zoom. Reproduce the reported case with zoom 2 and origin (0, 0), including a filtered object and a mask. Done when filtered objects and masks render in the correct position with non-default camera origins and zoom, while the reported working cases still work.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

When a camera has a zoom other than 1 and an origin other than the default 0.5 (e.g. setOrigin(0, 0)), game objects with filters render in the wrong place, usually off screen. This applies to internal and external filters, and to masks as well as other filters. Without filters, the same objects render correctly. It also works correctly at zoom 1, or with the default camera origin.

Version

  • Phaser Version:

Phaser 4.2.1, WebGL

  • Operating system:
    Linux (CachyOS)

  • Browser:
    Chrome

Description

Example Test Code

class S extends Phaser.Scene {
    create() {
        const cam = this.cameras.main.setZoom(2).setOrigin(0, 0)
        this.input.on('pointerdown', () => this.tweens.add({ targets: cam, zoom: cam.zoom > 1.5 ? 1 : 2, duration: 1000 }))
        this.add.rectangle(20, 20, 80, 60, 0x3399ff).setOrigin(0, 0)
        const filtered = this.add.rectangle(120, 20, 80, 60, 0x3399ff).setOrigin(0, 0)
        filtered.enableFilters().filters.internal.addColorMatrix().colorMatrix.grayscale()
        this.add.text(20, 90, 'Click to toggle the zoom', { fontSize: '10px' })
    }
}
new Phaser.Game({ type: Phaser.WEBGL, width: 800, height: 400, scene: S })

Additional Information

Suggested patch by claude which fixes it on my side bellow. Not knowledgable enough about Phaser internals to be confident it's the proper fix.

diff --git a/dist/phaser.esm.js b/dist/phaser.esm.js
index 8c6521ac895c8ba041b6990573cdb38e7210fec6..943448f360e4408348a5c243d965b645843cd2fb 100644
--- a/dist/phaser.esm.js
+++ b/dist/phaser.esm.js
@@ -47759,6 +47759,8 @@ if (true)
             this.filterCamera.setScroll(posX, posY);
             this.filterCamera.setRotation(rotation);
             this.filterCamera.setZoom(zoomX, zoomY);
+            this.filterCamera.setOrigin(camera.originX, camera.originY);
 
             return this;
         },
diff --git a/dist/phaser.js b/dist/phaser.js
index d5f7d60dd067d6a5b9d1fc2518b216f821f16e0c..0c53f1180482fb08a1e930fe08fc9db5164ef1db 100644
--- a/dist/phaser.js
+++ b/dist/phaser.js
@@ -47771,6 +47771,8 @@ if (true)
             this.filterCamera.setScroll(posX, posY);
             this.filterCamera.setRotation(rotation);
             this.filterCamera.setZoom(zoomX, zoomY);
+            this.filterCamera.setOrigin(camera.originX, camera.originY);
 
             return this;
         },
diff --git a/src/gameobjects/components/Filters.js b/src/gameobjects/components/Filters.js
index ba66b79e12b686cdb3d7244dfcd2dd59389c3432..358c408247319d9448d2be243d9f839f951bad8a 100644
--- a/src/gameobjects/components/Filters.js
+++ b/src/gameobjects/components/Filters.js
@@ -549,6 +549,8 @@ if (typeof WEBGL_RENDERER)
             this.filterCamera.setScroll(posX, posY);
             this.filterCamera.setRotation(rotation);
             this.filterCamera.setZoom(zoomX, zoomY);
+            this.filterCamera.setOrigin(camera.originX, camera.originY);
 
             return this;
         },
Lenguaje dominante
JavaScript
Estrellas
40.7k
Forks
7.2k
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de phaserjs/phaser

Todos los issues de phaserjs/phaser

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.