Filters on game objects are misplaced when the camera is zoomed and its origin isn't 0.5
维护者通常 3 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 62/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- javascript
调研方向
Start in src/gameobjects/components/Filters.js at the filter camera setup described in the suggested patch, then trace how the filter camera copies the main camera’s scroll, rotation, and zoom. Reproduce the reported case with zoom 2 and origin (0, 0), including a filtered object and a mask. Done when filtered objects and masks render in the correct position with non-default camera origins and zoom, while the reported working cases still work.
由索引模型根据 Issue 内容生成。
描述
When a camera has a zoom other than 1 and an origin other than the default 0.5 (e.g. setOrigin(0, 0)), game objects with filters render in the wrong place, usually off screen. This applies to internal and external filters, and to masks as well as other filters. Without filters, the same objects render correctly. It also works correctly at zoom 1, or with the default camera origin.
Version
- Phaser Version:
Phaser 4.2.1, WebGL
-
Operating system:
Linux (CachyOS) -
Browser:
Chrome
Description
Example Test Code
class S extends Phaser.Scene {
create() {
const cam = this.cameras.main.setZoom(2).setOrigin(0, 0)
this.input.on('pointerdown', () => this.tweens.add({ targets: cam, zoom: cam.zoom > 1.5 ? 1 : 2, duration: 1000 }))
this.add.rectangle(20, 20, 80, 60, 0x3399ff).setOrigin(0, 0)
const filtered = this.add.rectangle(120, 20, 80, 60, 0x3399ff).setOrigin(0, 0)
filtered.enableFilters().filters.internal.addColorMatrix().colorMatrix.grayscale()
this.add.text(20, 90, 'Click to toggle the zoom', { fontSize: '10px' })
}
}
new Phaser.Game({ type: Phaser.WEBGL, width: 800, height: 400, scene: S })
Additional Information
Suggested patch by claude which fixes it on my side bellow. Not knowledgable enough about Phaser internals to be confident it's the proper fix.
diff --git a/dist/phaser.esm.js b/dist/phaser.esm.js
index 8c6521ac895c8ba041b6990573cdb38e7210fec6..943448f360e4408348a5c243d965b645843cd2fb 100644
--- a/dist/phaser.esm.js
+++ b/dist/phaser.esm.js
@@ -47759,6 +47759,8 @@ if (true)
this.filterCamera.setScroll(posX, posY);
this.filterCamera.setRotation(rotation);
this.filterCamera.setZoom(zoomX, zoomY);
+ this.filterCamera.setOrigin(camera.originX, camera.originY);
return this;
},
diff --git a/dist/phaser.js b/dist/phaser.js
index d5f7d60dd067d6a5b9d1fc2518b216f821f16e0c..0c53f1180482fb08a1e930fe08fc9db5164ef1db 100644
--- a/dist/phaser.js
+++ b/dist/phaser.js
@@ -47771,6 +47771,8 @@ if (true)
this.filterCamera.setScroll(posX, posY);
this.filterCamera.setRotation(rotation);
this.filterCamera.setZoom(zoomX, zoomY);
+ this.filterCamera.setOrigin(camera.originX, camera.originY);
return this;
},
diff --git a/src/gameobjects/components/Filters.js b/src/gameobjects/components/Filters.js
index ba66b79e12b686cdb3d7244dfcd2dd59389c3432..358c408247319d9448d2be243d9f839f951bad8a 100644
--- a/src/gameobjects/components/Filters.js
+++ b/src/gameobjects/components/Filters.js
@@ -549,6 +549,8 @@ if (typeof WEBGL_RENDERER)
this.filterCamera.setScroll(posX, posY);
this.filterCamera.setRotation(rotation);
this.filterCamera.setZoom(zoomX, zoomY);
+ this.filterCamera.setOrigin(camera.originX, camera.originY);
return this;
},
- 主要语言
- JavaScript
- 星标
- 40.7k
- 派生
- 7.2k
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
phaserjs/phaser 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 80/100
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 80/100
维护者通常 3 天内回复
-
Type definition for TilemapLayer.getTileAt is wrong可能已有人在做 @hkbughk 于 34 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 3 天内回复
-
Shader.preDestroy leaks its ShaderQuad's vertex buffer and VAO on every create/destroy cycle (4.2.1)可能已有人在做 @k1epg01ng129-eng 于 32 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 86/100
维护者通常 3 天内回复
-
Black opaque background on transparent Phaser.Text textures in Phaser 4.2.1 on older iOS WebGL可能已有人在做 @SamuelMalmfors 于 14 天前认领。 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
phaserjs/phaser#7392 · 1 条评论 ·
维护者通常 3 天内回复
相似的 Issue
-
enhancement ready
难度 2/5 1-3 小时 新手友好度 84/100
-
enhancement
难度 2/5 1-3 小时 新手友好度 75/100
DCGM/semant-demo#708 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
-
agents area: runtime automation chore cli consistency dependencies developer-experience difficulty: easy documentation enhancement good first issue help wanted hygiene json-output priority: P3 starters tests
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
Client codegen: an import repeated in an impl file is emitted twice, and the browser rejects the module可能已有人在做 @MalithaPrabhashana 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 64/100
jaseci-labs/jac#10756 ·
维护者通常 1 天内回复