Halloween: remove jewel boxes from characters who have not entered since the event closed

Aperta
#3,587 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
70/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go, sqlite

Direzione di ricerca

Start at internal/game/enterworld/bootstrap.go, where RemoveExpiredHalloweenBoxes is called via deps.RemoveExpiredEventBoxes, and read that filter; it stays the single owner of the rule. Then find where the store loads and saves characters (the characters table in state.db, plus deleted_characters) and decide whether the sweep runs once after the window closes or is applied on the load path. Add a test with a stored offline character whose box disappears without an entry, then confirm a read-only count of state.db returns zero box rows.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: server bug priority: medium

Split from #2590 (done-when 1).

What the live shard shows

The Halloween window closed at 2026-11-15T00:00:00Z. The jewel box (ITEM_ETC_E050618_TREASUREBOX) is removed at world entry only (RemoveExpiredHalloweenBoxes, through deps.RemoveExpiredEventBoxes in internal/game/enterworld/bootstrap.go). A read-only production read later on 11-15 found:

  • 52 characters had entered since the close; none holds a box;
  • 204 characters had not entered since the close and still hold 409 box rows between them;
  • 2 deleted characters hold a box;
  • account storage and the ground hold none.

So the entry sweep works, but the live state does not reach zero until every one of those characters logs in, and some never will.

Done when

  • After the close, the stored records of characters who never enter again hold no box either. Either one sweep runs over the stored characters once the window has closed, or the store's load path applies the same removal (the sweep is the same filter as at entry, so RemoveExpiredHalloweenBoxes stays the one owner).
  • A read-only count of state.db shows zero box rows in characters, then the issue closes. deleted_characters either joins the sweep or the issue says why it is left.
  • A test covers a stored offline character whose box leaves without an entry.
Lingua principale
Go
Stelle
97
Fork
61
Merge medio
4h 14m
PR unite (30g)
913

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensro-dev/opensro

Tutte le issue di opensro-dev/opensro

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.