Halloween: remove jewel boxes from characters who have not entered since the event closed
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 70/100
调研方向
Start at internal/game/enterworld/bootstrap.go, where RemoveExpiredHalloweenBoxes is called via deps.RemoveExpiredEventBoxes, and read that filter; it stays the single owner of the rule. Then find where the store loads and saves characters (the characters table in state.db, plus deleted_characters) and decide whether the sweep runs once after the window closes or is applied on the load path. Add a test with a stored offline character whose box disappears without an entry, then confirm a read-only count of state.db returns zero box rows.
由索引模型根据 Issue 内容生成。
描述
Split from #2590 (done-when 1).
What the live shard shows
The Halloween window closed at 2026-11-15T00:00:00Z. The jewel box (ITEM_ETC_E050618_TREASUREBOX) is removed at world entry only (RemoveExpiredHalloweenBoxes, through deps.RemoveExpiredEventBoxes in internal/game/enterworld/bootstrap.go). A read-only production read later on 11-15 found:
- 52 characters had entered since the close; none holds a box;
- 204 characters had not entered since the close and still hold 409 box rows between them;
- 2 deleted characters hold a box;
- account storage and the ground hold none.
So the entry sweep works, but the live state does not reach zero until every one of those characters logs in, and some never will.
Done when
- After the close, the stored records of characters who never enter again hold no box either. Either one sweep runs over the stored characters once the window has closed, or the store's load path applies the same removal (the sweep is the same filter as at entry, so
RemoveExpiredHalloweenBoxesstays the one owner). - A read-only count of state.db shows zero box rows in
characters, then the issue closes.deleted_characterseither joins the sweep or the issue says why it is left. - A test covers a stored offline character whose box leaves without an entry.
- 主要语言
- Go
- 星标
- 97
- 派生
- 61
- 平均合并
- 4 小时 14 分钟
- 30 天内合并 PR
- 913
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
opensro-dev/opensro 的其他 Issue
-
area: client enhancement priority: low
难度 2/5 1-3 小时 新手友好度 75/100
opensro-dev/opensro#3681 ·
维护者通常 1 天内回复
-
area: client bug priority: low
难度 2/5 1-3 小时 新手友好度 78/100
opensro-dev/opensro#3228 · 1 条评论 ·
维护者通常 1 天内回复
-
Format one minified client file with dprint (ongoing: one file per PR)可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭area: client enhancement good first issue priority: low
难度 2/5 1-3 小时 新手友好度 75/100
opensro-dev/opensro#1 · 1 条评论 ·
维护者通常 1 天内回复
-
area: server bug priority: medium
难度 3/5 半天 新手友好度 55/100
opensro-dev/opensro#3687 ·
维护者通常 1 天内回复
-
area: ops bug priority: high
难度 4/5 3-5 天 新手友好度 32/100
opensro-dev/opensro#3685 ·
维护者通常 1 天内回复
查看 opensro-dev/opensro 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 66/100
unbound-force/gaze#353 ·
维护者通常 1 天内回复
-
bug cross-seed ready-for-human
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 64/100
OneBusAway/maglev#2102 ·
维护者通常 2 天内回复
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 70/100
Judgment-Pack/judgment-pack-gateway#474 ·
维护者通常 1 天内回复