Contributor title: an account made from a member's invite key can take the member's title

Aperta
#3,687 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go

Direzione di ricerca

Start with the operations sync that writes contributors.json and fills members[].accounts, then trace how /contributor here builds the member's group from that file — the contributor.go header comment describes the invite-key link you need to exclude. Compare that group-construction path against the OAuth sign-in records so you can tell an invite-linked account from a member-linked one. Done means the group only includes OAuth-linked accounts, plus a test asserting an invite-linked account gets ErrNotInGroup and a 404 from the website path.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: server bug priority: medium

The Contributor title (#3358, owner 2026-11-14 #3488) sits on one account per member, which the member can move "to another of their own". A member's group (contributors.json members[].accounts, written by the operations sync) holds every account linked to the member's Discord id. That includes accounts created from the member's invite keys (contributor.go header: "invite keys link any number of accounts to one Discord id").

An invite-made link is the key giver's Discord, not the player's (opensro-web#105, the account overview treats it as none). So a friend who signed up with the member's key is in the member's group, and can move the yellow title onto their own account: /contributor here in chat today, and the website's Carry it here once #3660 and web#154 land.

Fix

The group should hold only accounts linked by the member's own Discord sign-in (OAuth), not those linked through an invite key. That is the operations sync's input, plus a test that an invite-linked account gets ErrNotInGroup and answers 404 on the website.

Lingua principale
Go
Stelle
97
Fork
61
Merge medio
4h 14m
PR unite (30g)
913

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensro-dev/opensro

Tutte le issue di opensro-dev/opensro

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.