Halloween: remove jewel boxes from characters who have not entered since the event closed

Abierto
#3,587 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
70/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go, sqlite

Línea de trabajo

Start at internal/game/enterworld/bootstrap.go, where RemoveExpiredHalloweenBoxes is called via deps.RemoveExpiredEventBoxes, and read that filter; it stays the single owner of the rule. Then find where the store loads and saves characters (the characters table in state.db, plus deleted_characters) and decide whether the sweep runs once after the window closes or is applied on the load path. Add a test with a stored offline character whose box disappears without an entry, then confirm a read-only count of state.db returns zero box rows.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: server bug priority: medium

Split from #2590 (done-when 1).

What the live shard shows

The Halloween window closed at 2026-11-15T00:00:00Z. The jewel box (ITEM_ETC_E050618_TREASUREBOX) is removed at world entry only (RemoveExpiredHalloweenBoxes, through deps.RemoveExpiredEventBoxes in internal/game/enterworld/bootstrap.go). A read-only production read later on 11-15 found:

  • 52 characters had entered since the close; none holds a box;
  • 204 characters had not entered since the close and still hold 409 box rows between them;
  • 2 deleted characters hold a box;
  • account storage and the ground hold none.

So the entry sweep works, but the live state does not reach zero until every one of those characters logs in, and some never will.

Done when

  • After the close, the stored records of characters who never enter again hold no box either. Either one sweep runs over the stored characters once the window has closed, or the store's load path applies the same removal (the sweep is the same filter as at entry, so RemoveExpiredHalloweenBoxes stays the one owner).
  • A read-only count of state.db shows zero box rows in characters, then the issue closes. deleted_characters either joins the sweep or the issue says why it is left.
  • A test covers a stored offline character whose box leaves without an entry.
Lenguaje dominante
Go
Estrellas
97
Forks
61
Merge medio
4 h 14 min
PR fusionados (30 d)
913

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de opensro-dev/opensro

Todos los issues de opensro-dev/opensro

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.