Halloween: remove jewel boxes from characters who have not entered since the event closed
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 70/100
Línea de trabajo
Start at internal/game/enterworld/bootstrap.go, where RemoveExpiredHalloweenBoxes is called via deps.RemoveExpiredEventBoxes, and read that filter; it stays the single owner of the rule. Then find where the store loads and saves characters (the characters table in state.db, plus deleted_characters) and decide whether the sweep runs once after the window closes or is applied on the load path. Add a test with a stored offline character whose box disappears without an entry, then confirm a read-only count of state.db returns zero box rows.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Split from #2590 (done-when 1).
What the live shard shows
The Halloween window closed at 2026-11-15T00:00:00Z. The jewel box (ITEM_ETC_E050618_TREASUREBOX) is removed at world entry only (RemoveExpiredHalloweenBoxes, through deps.RemoveExpiredEventBoxes in internal/game/enterworld/bootstrap.go). A read-only production read later on 11-15 found:
- 52 characters had entered since the close; none holds a box;
- 204 characters had not entered since the close and still hold 409 box rows between them;
- 2 deleted characters hold a box;
- account storage and the ground hold none.
So the entry sweep works, but the live state does not reach zero until every one of those characters logs in, and some never will.
Done when
- After the close, the stored records of characters who never enter again hold no box either. Either one sweep runs over the stored characters once the window has closed, or the store's load path applies the same removal (the sweep is the same filter as at entry, so
RemoveExpiredHalloweenBoxesstays the one owner). - A read-only count of state.db shows zero box rows in
characters, then the issue closes.deleted_characterseither joins the sweep or the issue says why it is left. - A test covers a stored offline character whose box leaves without an entry.
- Lenguaje dominante
- Go
- Estrellas
- 97
- Forks
- 61
- Merge medio
- 4 h 14 min
- PR fusionados (30 d)
- 913
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de opensro-dev/opensro
-
area: client enhancement priority: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
opensro-dev/opensro#3681 ·
Los mantenedores suelen responder en 1 día
-
area: client bug priority: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
opensro-dev/opensro#3228 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Format one minified client file with dprint (ongoing: one file per PR)Posiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertoarea: client enhancement good first issue priority: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
opensro-dev/opensro#1 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
area: server bug priority: medium
Dificultad 3/5 Medio día Aptitud para principiantes 55/100
opensro-dev/opensro#3687 ·
Los mantenedores suelen responder en 1 día
-
area: ops bug priority: high
Dificultad 4/5 3-5 días Aptitud para principiantes 32/100
opensro-dev/opensro#3685 ·
Los mantenedores suelen responder en 1 día
Todos los issues de opensro-dev/opensro
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
unbound-force/gaze#353 ·
Los mantenedores suelen responder en 1 día
-
bug cross-seed ready-for-human
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
OneBusAway/maglev#2102 ·
Los mantenedores suelen responder en 2 días
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
Waiting start: the fixed 503 body says another instance holds the lease when that may not be soAbierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 70/100
Judgment-Pack/judgment-pack-gateway#474 ·
Los mantenedores suelen responder en 1 día