Halloween: remove jewel boxes from characters who have not entered since the event closed

オープン
#3,587 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
70/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
go, sqlite

調査の方向性

Start at internal/game/enterworld/bootstrap.go, where RemoveExpiredHalloweenBoxes is called via deps.RemoveExpiredEventBoxes, and read that filter; it stays the single owner of the rule. Then find where the store loads and saves characters (the characters table in state.db, plus deleted_characters) and decide whether the sweep runs once after the window closes or is applied on the load path. Add a test with a stored offline character whose box disappears without an entry, then confirm a read-only count of state.db returns zero box rows.

索引モデルが issue の本文から書いたものです。

説明

area: server bug priority: medium

Split from #2590 (done-when 1).

What the live shard shows

The Halloween window closed at 2026-11-15T00:00:00Z. The jewel box (ITEM_ETC_E050618_TREASUREBOX) is removed at world entry only (RemoveExpiredHalloweenBoxes, through deps.RemoveExpiredEventBoxes in internal/game/enterworld/bootstrap.go). A read-only production read later on 11-15 found:

  • 52 characters had entered since the close; none holds a box;
  • 204 characters had not entered since the close and still hold 409 box rows between them;
  • 2 deleted characters hold a box;
  • account storage and the ground hold none.

So the entry sweep works, but the live state does not reach zero until every one of those characters logs in, and some never will.

Done when

  • After the close, the stored records of characters who never enter again hold no box either. Either one sweep runs over the stored characters once the window has closed, or the store's load path applies the same removal (the sweep is the same filter as at entry, so RemoveExpiredHalloweenBoxes stays the one owner).
  • A read-only count of state.db shows zero box rows in characters, then the issue closes. deleted_characters either joins the sweep or the issue says why it is left.
  • A test covers a stored offline character whose box leaves without an entry.
主要言語
Go
スター
97
フォーク
61
平均マージ
4時間 14分
マージ済み PR(30日)
913

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

opensro-dev/opensro のほかの issue

opensro-dev/opensro の issue をすべて見る

似ている issue

Go の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。