client: the berserk red look flickers while the gauge empties, and dress wings stay uncoloured

Aperta
#3,543 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
32/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
game-dev, typescript
Ambito
game-dev

Direzione di ricerca

Start in effects.ts near line 1380, where the appearance byte at +0x2B6 (1 = berserk) is read, and in feedback.ts where the 0x30B3 sub-op 4 gauge updates arrive. Work out whether the berserk tint is cleared or re-derived as the gauge drops, and how the wing attachment path differs from body parts. The native rule for when the look holds comes from the client disassembly at 85C590, which a newcomer will need to read. Done when the flicker cause is fixed and tests cover both the body tint and the angel and devil dress wings.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: client bug priority: medium

Report: https://discord.com/channels/1550530470430396426/1570778021378531359 (in-game report with replay and diagnostics, 2026-11-13)

Two observations from the report:

  1. The berserk red colour flickers while the gauge empties. During berserk, as the orb tubes drain, the character's red berserk look disappears and comes back.
  2. The angel and devil dress wings do not take the berserk red. The rest of the character turns red, but the wings keep their own colour.

Where to start

  • effects.ts (around line 1380) reads appearance state byte 2 (+0x2B6, 1 = berserk). Native 85C590 skips every material call while that byte is 1. Check whether the byte, or the tint that depends on it, toggles as the gauge counts down (0x30B3 sub-op 4 gauge updates in feedback.ts). If the tint re-derives on each gauge update, a drop below full may clear it until the next update.
  • The wings are an avatar attachment. Check whether the berserk tint pass reaches attachment and avatar parts as it does body parts, and what the native client does for them. Read the native draw path before deciding.

Done when

  • The cause of the flicker is named, with the native rule for when the berserk look holds (from the client disassembly), and fixed.
  • Wings (angel and devil dresses) follow the native rule for the berserk tint, whichever way the native client draws them.
  • Tests pin both.
Lingua principale
Go
Stelle
97
Fork
61
Merge medio
4h 14m
PR unite (30g)
913

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensro-dev/opensro

Tutte le issue di opensro-dev/opensro

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.