client: the berserk red look flickers while the gauge empties, and dress wings stay uncoloured

Abierto
#3,543 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
32/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
game-dev, typescript
Área
game-dev

Línea de trabajo

Start in effects.ts near line 1380, where the appearance byte at +0x2B6 (1 = berserk) is read, and in feedback.ts where the 0x30B3 sub-op 4 gauge updates arrive. Work out whether the berserk tint is cleared or re-derived as the gauge drops, and how the wing attachment path differs from body parts. The native rule for when the look holds comes from the client disassembly at 85C590, which a newcomer will need to read. Done when the flicker cause is fixed and tests cover both the body tint and the angel and devil dress wings.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: client bug priority: medium

Report: https://discord.com/channels/1550530470430396426/1570778021378531359 (in-game report with replay and diagnostics, 2026-11-13)

Two observations from the report:

  1. The berserk red colour flickers while the gauge empties. During berserk, as the orb tubes drain, the character's red berserk look disappears and comes back.
  2. The angel and devil dress wings do not take the berserk red. The rest of the character turns red, but the wings keep their own colour.

Where to start

  • effects.ts (around line 1380) reads appearance state byte 2 (+0x2B6, 1 = berserk). Native 85C590 skips every material call while that byte is 1. Check whether the byte, or the tint that depends on it, toggles as the gauge counts down (0x30B3 sub-op 4 gauge updates in feedback.ts). If the tint re-derives on each gauge update, a drop below full may clear it until the next update.
  • The wings are an avatar attachment. Check whether the berserk tint pass reaches attachment and avatar parts as it does body parts, and what the native client does for them. Read the native draw path before deciding.

Done when

  • The cause of the flicker is named, with the native rule for when the berserk look holds (from the client disassembly), and fixed.
  • Wings (angel and devil dresses) follow the native rule for the berserk tint, whichever way the native client draws them.
  • Tests pin both.
Lenguaje dominante
Go
Estrellas
97
Forks
61
Merge medio
4 h 14 min
PR fusionados (30 d)
913

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de opensro-dev/opensro

Todos los issues de opensro-dev/opensro

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.