client: the berserk red look flickers while the gauge empties, and dress wings stay uncoloured

Offen
#3,543 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
32/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
game-dev, typescript
Bereich
game-dev

Rechercherichtung

Start in effects.ts near line 1380, where the appearance byte at +0x2B6 (1 = berserk) is read, and in feedback.ts where the 0x30B3 sub-op 4 gauge updates arrive. Work out whether the berserk tint is cleared or re-derived as the gauge drops, and how the wing attachment path differs from body parts. The native rule for when the look holds comes from the client disassembly at 85C590, which a newcomer will need to read. Done when the flicker cause is fixed and tests cover both the body tint and the angel and devil dress wings.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area: client bug priority: medium

Report: https://discord.com/channels/1550530470430396426/1570778021378531359 (in-game report with replay and diagnostics, 2026-11-13)

Two observations from the report:

  1. The berserk red colour flickers while the gauge empties. During berserk, as the orb tubes drain, the character's red berserk look disappears and comes back.
  2. The angel and devil dress wings do not take the berserk red. The rest of the character turns red, but the wings keep their own colour.

Where to start

  • effects.ts (around line 1380) reads appearance state byte 2 (+0x2B6, 1 = berserk). Native 85C590 skips every material call while that byte is 1. Check whether the byte, or the tint that depends on it, toggles as the gauge counts down (0x30B3 sub-op 4 gauge updates in feedback.ts). If the tint re-derives on each gauge update, a drop below full may clear it until the next update.
  • The wings are an avatar attachment. Check whether the berserk tint pass reaches attachment and avatar parts as it does body parts, and what the native client does for them. Read the native draw path before deciding.

Done when

  • The cause of the flicker is named, with the native rule for when the berserk look holds (from the client disassembly), and fixed.
  • Wings (angel and devil dresses) follow the native rule for the berserk tint, whichever way the native client draws them.
  • Tests pin both.
Vorherrschende Sprache
Go
Sterne
97
Forks
61
Ø Merge
4 Std. 14 Min.
Gemergte PRs (30 T.)
913

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus opensro-dev/opensro

Alle Issues in opensro-dev/opensro

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.