client: the berserk red look flickers while the gauge empties, and dress wings stay uncoloured

Aberta
#3,543 2 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
32/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
game-dev, typescript
Domínio
game-dev

Direção de pesquisa

Start in effects.ts near line 1380, where the appearance byte at +0x2B6 (1 = berserk) is read, and in feedback.ts where the 0x30B3 sub-op 4 gauge updates arrive. Work out whether the berserk tint is cleared or re-derived as the gauge drops, and how the wing attachment path differs from body parts. The native rule for when the look holds comes from the client disassembly at 85C590, which a newcomer will need to read. Done when the flicker cause is fixed and tests cover both the body tint and the angel and devil dress wings.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area: client bug priority: medium

Report: https://discord.com/channels/1550530470430396426/1570778021378531359 (in-game report with replay and diagnostics, 2026-11-13)

Two observations from the report:

  1. The berserk red colour flickers while the gauge empties. During berserk, as the orb tubes drain, the character's red berserk look disappears and comes back.
  2. The angel and devil dress wings do not take the berserk red. The rest of the character turns red, but the wings keep their own colour.

Where to start

  • effects.ts (around line 1380) reads appearance state byte 2 (+0x2B6, 1 = berserk). Native 85C590 skips every material call while that byte is 1. Check whether the byte, or the tint that depends on it, toggles as the gauge counts down (0x30B3 sub-op 4 gauge updates in feedback.ts). If the tint re-derives on each gauge update, a drop below full may clear it until the next update.
  • The wings are an avatar attachment. Check whether the berserk tint pass reaches attachment and avatar parts as it does body parts, and what the native client does for them. Read the native draw path before deciding.

Done when

  • The cause of the flicker is named, with the native rule for when the berserk look holds (from the client disassembly), and fixed.
  • Wings (angel and devil dresses) follow the native rule for the berserk tint, whichever way the native client draws them.
  • Tests pin both.
Linguagem predominante
Go
Estrelas
97
Forks
61
Merge médio
4h 14min
PRs com merge (30d)
913

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de opensro-dev/opensro

Todas as issues de opensro-dev/opensro

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.