Later-client importers read the stale plain skilldata tables instead of the client's encrypted set

Aperta
#3,374 5 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
45/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
data

Direzione di ricerca

Start with the client_skill_rows(read, has) helper that #3373 adds in scripts/skilldata_enc.py, and confirm it is merged before you begin. Then change the plain skilldata read at the six importer lines named in the issue (arabia_import.py:484, cap110_skill_import.py:54, hunting2_import.py:268, later_world_import.py:370, muhan_import.py:374, skytemple_import.py:621) to go through the helper. Done means each importer's staged output diff (added skills and changed rows) is recorded on its PR and no already-shipped row changes identity.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: server bug priority: medium

Follow-up of #3373.

The VSRO client (and any later client that ships skilldataenc.txt) reads its skills from the encrypted SkillData_<n>ENC.txt shards. The plain skilldata*.txt beside them is an older copy. In the pinned VSRO Media.pk2 it has 29,334 rows against 31,400, and lacks at least 113 Egypt monster skills. #3373 adds scripts/skilldata_enc.py (client_skill_rows(read, has)) and moves cap110_monsters onto it.

These importers still read a later client's plain manifest directly:

  • scripts/arabia_import.py:484
  • scripts/cap110_skill_import.py:54
  • scripts/hunting2_import.py:268
  • scripts/later_world_import.py:370
  • scripts/muhan_import.py:374
  • scripts/skytemple_import.py:621

Each should read through client_skill_rows. Switching changes what they import, so for each one:

  1. Diff its staged output before and after the switch (added skills, changed rows).
  2. Confirm that no row it already ships changes identity.

Done when all six read through the one owner, and each diff is recorded on its PR.

Lingua principale
Go
Stelle
97
Fork
61
Merge medio
4h 14m
PR unite (30g)
913

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensro-dev/opensro

Tutte le issue di opensro-dev/opensro

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.