Later-client importers read the stale plain skilldata tables instead of the client's encrypted set

Offen
#3,374 5 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
45/100
Issue-Typ
Refactoring
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
python
Bereich
data

Rechercherichtung

Start with the client_skill_rows(read, has) helper that #3373 adds in scripts/skilldata_enc.py, and confirm it is merged before you begin. Then change the plain skilldata read at the six importer lines named in the issue (arabia_import.py:484, cap110_skill_import.py:54, hunting2_import.py:268, later_world_import.py:370, muhan_import.py:374, skytemple_import.py:621) to go through the helper. Done means each importer's staged output diff (added skills and changed rows) is recorded on its PR and no already-shipped row changes identity.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area: server bug priority: medium

Follow-up of #3373.

The VSRO client (and any later client that ships skilldataenc.txt) reads its skills from the encrypted SkillData_<n>ENC.txt shards. The plain skilldata*.txt beside them is an older copy. In the pinned VSRO Media.pk2 it has 29,334 rows against 31,400, and lacks at least 113 Egypt monster skills. #3373 adds scripts/skilldata_enc.py (client_skill_rows(read, has)) and moves cap110_monsters onto it.

These importers still read a later client's plain manifest directly:

  • scripts/arabia_import.py:484
  • scripts/cap110_skill_import.py:54
  • scripts/hunting2_import.py:268
  • scripts/later_world_import.py:370
  • scripts/muhan_import.py:374
  • scripts/skytemple_import.py:621

Each should read through client_skill_rows. Switching changes what they import, so for each one:

  1. Diff its staged output before and after the switch (added skills, changed rows).
  2. Confirm that no row it already ships changes identity.

Done when all six read through the one owner, and each diff is recorded on its PR.

Vorherrschende Sprache
Go
Sterne
97
Forks
61
Ø Merge
4 Std. 14 Min.
Gemergte PRs (30 T.)
913

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus opensro-dev/opensro

Alle Issues in opensro-dev/opensro

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.