Later-client importers read the stale plain skilldata tables instead of the client's encrypted set

Ouverte
#3,374 5 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
45/100
Type d'issue
Refactorisation
Clarté
Plutôt claire
Activité
Active
Stack technique
python
Domaine
data

Piste de recherche

Start with the client_skill_rows(read, has) helper that #3373 adds in scripts/skilldata_enc.py, and confirm it is merged before you begin. Then change the plain skilldata read at the six importer lines named in the issue (arabia_import.py:484, cap110_skill_import.py:54, hunting2_import.py:268, later_world_import.py:370, muhan_import.py:374, skytemple_import.py:621) to go through the helper. Done means each importer's staged output diff (added skills and changed rows) is recorded on its PR and no already-shipped row changes identity.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area: server bug priority: medium

Follow-up of #3373.

The VSRO client (and any later client that ships skilldataenc.txt) reads its skills from the encrypted SkillData_<n>ENC.txt shards. The plain skilldata*.txt beside them is an older copy. In the pinned VSRO Media.pk2 it has 29,334 rows against 31,400, and lacks at least 113 Egypt monster skills. #3373 adds scripts/skilldata_enc.py (client_skill_rows(read, has)) and moves cap110_monsters onto it.

These importers still read a later client's plain manifest directly:

  • scripts/arabia_import.py:484
  • scripts/cap110_skill_import.py:54
  • scripts/hunting2_import.py:268
  • scripts/later_world_import.py:370
  • scripts/muhan_import.py:374
  • scripts/skytemple_import.py:621

Each should read through client_skill_rows. Switching changes what they import, so for each one:

  1. Diff its staged output before and after the switch (added skills, changed rows).
  2. Confirm that no row it already ships changes identity.

Done when all six read through the one owner, and each diff is recorded on its PR.

Langage dominant
Go
Étoiles
97
Forks
61
Merge moyen
4 h 14 min
PR mergées (30 j)
913

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de opensro-dev/opensro

Toutes les issues de opensro-dev/opensro

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.