Later-client importers read the stale plain skilldata tables instead of the client's encrypted set

未关闭
#3,374 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
45/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
data

调研方向

Start with the client_skill_rows(read, has) helper that #3373 adds in scripts/skilldata_enc.py, and confirm it is merged before you begin. Then change the plain skilldata read at the six importer lines named in the issue (arabia_import.py:484, cap110_skill_import.py:54, hunting2_import.py:268, later_world_import.py:370, muhan_import.py:374, skytemple_import.py:621) to go through the helper. Done means each importer's staged output diff (added skills and changed rows) is recorded on its PR and no already-shipped row changes identity.

由索引模型根据 Issue 内容生成。

描述

area: server bug priority: medium

Follow-up of #3373.

The VSRO client (and any later client that ships skilldataenc.txt) reads its skills from the encrypted SkillData_<n>ENC.txt shards. The plain skilldata*.txt beside them is an older copy. In the pinned VSRO Media.pk2 it has 29,334 rows against 31,400, and lacks at least 113 Egypt monster skills. #3373 adds scripts/skilldata_enc.py (client_skill_rows(read, has)) and moves cap110_monsters onto it.

These importers still read a later client's plain manifest directly:

  • scripts/arabia_import.py:484
  • scripts/cap110_skill_import.py:54
  • scripts/hunting2_import.py:268
  • scripts/later_world_import.py:370
  • scripts/muhan_import.py:374
  • scripts/skytemple_import.py:621

Each should read through client_skill_rows. Switching changes what they import, so for each one:

  1. Diff its staged output before and after the switch (added skills, changed rows).
  2. Confirm that no row it already ships changes identity.

Done when all six read through the one owner, and each diff is recorded on its PR.

主要语言
Go
星标
97
派生
61
平均合并
4 小时 14 分钟
30 天内合并 PR
913

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

opensro-dev/opensro 的其他 Issue

查看 opensro-dev/opensro 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。