Later-client importers read the stale plain skilldata tables instead of the client's encrypted set
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the client_skill_rows(read, has) helper that #3373 adds in scripts/skilldata_enc.py, and confirm it is merged before you begin. Then change the plain skilldata read at the six importer lines named in the issue (arabia_import.py:484, cap110_skill_import.py:54, hunting2_import.py:268, later_world_import.py:370, muhan_import.py:374, skytemple_import.py:621) to go through the helper. Done means each importer's staged output diff (added skills and changed rows) is recorded on its PR and no already-shipped row changes identity.
由索引模型根据 Issue 内容生成。
描述
Follow-up of #3373.
The VSRO client (and any later client that ships skilldataenc.txt) reads its skills from the encrypted SkillData_<n>ENC.txt shards. The plain skilldata*.txt beside them is an older copy. In the pinned VSRO Media.pk2 it has 29,334 rows against 31,400, and lacks at least 113 Egypt monster skills. #3373 adds scripts/skilldata_enc.py (client_skill_rows(read, has)) and moves cap110_monsters onto it.
These importers still read a later client's plain manifest directly:
scripts/arabia_import.py:484scripts/cap110_skill_import.py:54scripts/hunting2_import.py:268scripts/later_world_import.py:370scripts/muhan_import.py:374scripts/skytemple_import.py:621
Each should read through client_skill_rows. Switching changes what they import, so for each one:
- Diff its staged output before and after the switch (added skills, changed rows).
- Confirm that no row it already ships changes identity.
Done when all six read through the one owner, and each diff is recorded on its PR.
- 主要语言
- Go
- 星标
- 97
- 派生
- 61
- 平均合并
- 4 小时 14 分钟
- 30 天内合并 PR
- 913
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
opensro-dev/opensro 的其他 Issue
-
area: client enhancement priority: low
难度 2/5 1-3 小时 新手友好度 75/100
opensro-dev/opensro#3681 ·
维护者通常 1 天内回复
-
area: client bug priority: low
难度 2/5 1-3 小时 新手友好度 78/100
opensro-dev/opensro#3228 · 1 条评论 ·
维护者通常 1 天内回复
-
Format one minified client file with dprint (ongoing: one file per PR)可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭area: client enhancement good first issue priority: low
难度 2/5 1-3 小时 新手友好度 75/100
opensro-dev/opensro#1 · 1 条评论 ·
维护者通常 1 天内回复
-
area: server bug priority: medium
难度 3/5 半天 新手友好度 55/100
opensro-dev/opensro#3687 ·
维护者通常 1 天内回复
-
area: ops bug priority: high
难度 4/5 3-5 天 新手友好度 32/100
opensro-dev/opensro#3685 ·
维护者通常 1 天内回复
查看 opensro-dev/opensro 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 66/100
unbound-force/gaze#353 ·
维护者通常 1 天内回复
-
bug cross-seed ready-for-human
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 64/100
OneBusAway/maglev#2102 ·
维护者通常 2 天内回复
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 70/100
Judgment-Pack/judgment-pack-gateway#474 ·
维护者通常 1 天内回复