Review player: show clicks and captions on the timeline

Aperta
#378 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
57/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript

Direzione di ricerca

Start with src/tools/reviewRecording.ts to see how player_frames builds its payload, then read assets/ui/player.js for the timeline and frame display. Check src/utils/events.ts, src/tools/readEvents.ts, and src/tools/transcribe.ts for the event log and SRT sidecar formats. Done means both tracks can be toggled, clicks seek and show their frame position, captions follow the current frame and can seek, and a 10k-event log keeps the payload bounded.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

effort: medium enhancement help wanted priority: medium

Summary

The review player's timeline shows scene changes and markers, but not what happened: no clicks or keystrokes from the event log, and no captions. Finding "the moment after the Save click" means scrubbing frame by frame, even when the server already knows when every click happened.

Where

  • src/tools/reviewRecording.ts:51-53, 106 (player data carries markers only)
  • assets/ui/player.js:118-143 (renders scene ticks and markers only)
  • src/utils/events.ts, src/tools/readEvents.ts (event log on the video clock)
  • src/tools/transcribe.ts (SRT sidecar)

Suggested fix

  • Include a compact clicks list (t, button, x/y, and the UI element name from #333 when present) and captions (t, end, text) in the player_frames result when the sidecars exist. Cap the counts.
  • Draw click ticks as a second row under the timeline. Hovering or focusing one shows a crosshair on the frame at the click point.
  • Show the caption for the current frame under the stage, and make caption lines clickable to seek.
  • Both tracks can be toggled off.

Acceptance criteria

  • Recordings with an event log show click ticks that seek on activation
  • Recordings with an SRT show the current caption
  • Recordings without sidecars look the same as today
  • Payload stays bounded (test with a 10k-event log)

Getting started

  • Relevant files: src/tools/reviewRecording.ts, assets/ui/player.js, src/utils/events.ts

Filed by repo-audit/feature-ideas at 1ac339f. Severity: medium. Effort: M. audit-key: enhancement|src/tools/reviewRecording.ts|tracks

Lingua principale
TypeScript
Stelle
1
Fork
4
Merge medio
8h 17m
PR unite (30g)
46

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/screencast-mcp

Tutte le issue di TMHSDigital/screencast-mcp

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.