Regression: game.js still holds eight jobs in one 1,862-line scope
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 35/100
- Issue-Typ
- Refactoring
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- javascript
- Bereich
- backend
Rechercherichtung
Read js/game.js alongside js/notation.js, js/saved-game.js, and js/rules.js; start with the proposed playersFromPGN and replayUndoStack extractions and add direct unit tests for them. Then review statusForOutcome, describeMove, and the material count, using tests/helpers/load-game.js and npm test as described. Done means steps 1–4 are extracted, each extraction is committed separately, and the full suite passes after each.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
#89 split some UI code out (game-ui.js), but js/game.js is still one 1,862-line script. It shares about 30 mutable top-level lets across eight jobs and is the most-changed file in the repo (74 of the last 200 commits). Several functions in it are pure, or close to pure, and can move out with little risk.
Where
js/game.js:6-56: live state, about 30letsjs/game.js:357-595: review and autoplayjs/game.js:1101-1215: clockjs/game.js:1345-1430: persistence and replayjs/game.js:1599-1764: PGN/FEN export and importjs/game.js:1766-1862: exports, including 15 getters only tests use
Details
The file's own section comments list its jobs: move flow, review and autoplay, ending a game without a move, the computer opponent, the clock, hints, persistence and replay, past games, view models, and PGN/FEN import and export.
Functions here that are pure or nearly pure:
replayUndoStack(start, moves, saved), around line 1400playersFromPGN(text), around line 1720statusForOutcome, around line 717- the material count in
updateCapturedDisplay, around lines 1496-1501 isThreefoldRepetition, around line 1293
Impact
Every recent feature (Redo, the Play button, random side, rebuilding the undo stack on load) had to edit this file and keep all of its globals in mind. Pure logic in it can only be tested by loading the whole page in jsdom (tests/helpers/load-game.js).
Suggested fix
Extract in small PRs, pure code first. Keep the old global name as a one-line alias until its callers move, so every PR leaves the page working.
- Move
playersFromPGNtonotation.js. - Move
replayUndoStacktosaved-game.jsorrules.js, asrebuildUndoStack(start, moves, savedKey). - Move
statusForOutcomeand the move sentence ofdescribeMoveinto a small text module, or intoreview.js. - Move the material count into
rules.jsasmaterialBalance(board). - Only then consider extracting the clock section behind an object that
game.jsowns.
Acceptance criteria
- Before starting: unit tests that call
replayUndoStackandplayersFromPGNdirectly, and characterization tests for thedescribeMovetext of castling, en passant, promotion and check. - Each extraction is its own commit, and the full suite passes after each one.
-
game.jsloses steps 1-4.
Getting started
- Relevant files:
js/game.js,js/notation.js,js/saved-game.js,js/rules.js,tests/helpers/load-game.js - How to run tests:
npm test
Regression of #89.
Filed by repo-audit/full-audit at 01c6a35. Severity: medium. Effort: L. audit-key: tech-debt|js/game.js|module-structure
- Vorherrschende Sprache
- JavaScript
- Sterne
- 4
- Forks
- 2
- Ø Merge
- 22 Std. 16 Min.
- Gemergte PRs (30 T.)
- 9
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus TMHSDigital/Static_Chess
-
enhancement help wanted severity: low
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 55/100
TMHSDigital/Static_Chess#184 ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement help wanted severity: low
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 58/100
TMHSDigital/Static_Chess#182 ·
Maintainer antworten meist innerhalb von 1 Tag
-
help wanted severity: medium tech-debt
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 45/100
TMHSDigital/Static_Chess#173 ·
Maintainer antworten meist innerhalb von 1 Tag
-
help wanted performance severity: medium
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 38/100
TMHSDigital/Static_Chess#168 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement help wanted severity: low
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 61/100
TMHSDigital/Static_Chess#161 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in TMHSDigital/Static_Chess
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
cytoscape/cytoscape.js#3597 ·
Maintainer antworten meist innerhalb von 5 Tagen
-
priority: low server testing
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
blamechris/chroxy#9277 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 72/100
sunososobro-hub/cloudball#191 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
microsoft/playwright#44289 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Wire ISO post: has() accepts text values such as an empty string, true or 0x1A for wire numbersOffenarea:post effort:low enhancement P7 source:agent
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
Maintainer antworten meist innerhalb von 1 Tag