Follow-ups left open by the busy-window session-lifetime fix (#442)

Aperta
#443 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c, shell
Ambito
embedded-iot

Direzione di ricerca

Read the Jaguar-family Stop() and with_ccx implementations, the RTL8733B override for comparison, and the documented IRadio::ArmChannelBusy contract. Also inspect tests/busy_window_probe.sh and the relevant src/<gen>/CLAUDE.md files; validate the proposed lifecycle and locking changes with the probe, including its revive mode and reps 2..N. Done means the three follow-ups are addressed and the behavior change is measured.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Left open by the busy-window session-lifetime fix (#442, merged as 09eb26a). Closes item 2 of #441.

1. An arm issued AFTER Stop() still succeeds on Jaguar1/2/3

#442 makes Stop() forget a window armed before the teardown. It does not close the other direction: with_ccx on the three Jaguar families gates on _brought_up, which no Stop() clears, so ArmChannelBusy() after a Stop() arms a torn-down chip and the read touches CCX registers on it. The RTL8733B closes this (its Stop() clears _phy_ready under the recursive _reg_mu it holds for the whole body); the Jaguars have neither half. Documented at IRadio::ArmChannelBusy and in each src/<gen>/CLAUDE.md.

Closing it means clearing _brought_up in the Jaguar Stop()s, which gates other paths (the band_change TXAGC re-fold in FastRetune, among others), so it is a behaviour change on its own and wants its own measurement — tests/busy_window_probe.sh --mode revive reps 2..N are exactly the sequence that would start refusing.

2. Jaguar2/3 with_ccx reads _brought_up before taking _reg_mu

Both overrides check the flag unlocked and then take _reg_mu. The RTL8733B override's comment already names the shape: a data race on the flag, and a TOCTOU where the check passes, the lock blocks behind a concurrent Stop(), and the register access proceeds against a card that has just been powered down. Pre-existing; with_ccx is single-control-thread by contract so it is latent, but it costs nothing to read the flag under the lock, and item 1 makes the flag load-bearing.

3. tests/busy_window_probe.sh: stale arm body left indented

#442 removed the tautological if [ "$realtek_sensor" = "1" ] around the stale arm but left its body indented one level. Cosmetic.

Lingua principale
C
Stelle
56
Fork
29
Merge medio
3h 43m
PR unite (30g)
75

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenIPC/devourer

Tutte le issue di OpenIPC/devourer

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.