Follow-ups left open by the busy-window session-lifetime fix (#442)

Abierto
#443 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c, shell
Área
embedded-iot

Línea de trabajo

Read the Jaguar-family Stop() and with_ccx implementations, the RTL8733B override for comparison, and the documented IRadio::ArmChannelBusy contract. Also inspect tests/busy_window_probe.sh and the relevant src/<gen>/CLAUDE.md files; validate the proposed lifecycle and locking changes with the probe, including its revive mode and reps 2..N. Done means the three follow-ups are addressed and the behavior change is measured.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Left open by the busy-window session-lifetime fix (#442, merged as 09eb26a). Closes item 2 of #441.

1. An arm issued AFTER Stop() still succeeds on Jaguar1/2/3

#442 makes Stop() forget a window armed before the teardown. It does not close the other direction: with_ccx on the three Jaguar families gates on _brought_up, which no Stop() clears, so ArmChannelBusy() after a Stop() arms a torn-down chip and the read touches CCX registers on it. The RTL8733B closes this (its Stop() clears _phy_ready under the recursive _reg_mu it holds for the whole body); the Jaguars have neither half. Documented at IRadio::ArmChannelBusy and in each src/<gen>/CLAUDE.md.

Closing it means clearing _brought_up in the Jaguar Stop()s, which gates other paths (the band_change TXAGC re-fold in FastRetune, among others), so it is a behaviour change on its own and wants its own measurement — tests/busy_window_probe.sh --mode revive reps 2..N are exactly the sequence that would start refusing.

2. Jaguar2/3 with_ccx reads _brought_up before taking _reg_mu

Both overrides check the flag unlocked and then take _reg_mu. The RTL8733B override's comment already names the shape: a data race on the flag, and a TOCTOU where the check passes, the lock blocks behind a concurrent Stop(), and the register access proceeds against a card that has just been powered down. Pre-existing; with_ccx is single-control-thread by contract so it is latent, but it costs nothing to read the flag under the lock, and item 1 makes the flag load-bearing.

3. tests/busy_window_probe.sh: stale arm body left indented

#442 removed the tautological if [ "$realtek_sensor" = "1" ] around the stale arm but left its body indented one level. Cosmetic.

Lenguaje dominante
C
Estrellas
56
Forks
29
Merge medio
3 h 43 min
PR fusionados (30 d)
75

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenIPC/devourer

Todos los issues de OpenIPC/devourer

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.