Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Main video stays paused when a playing video comment is removed

Chiusa
  • Qualcosa non va?
#2,796 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Una pull request collegata è già stata integrata.

  • #2797 di @AksharP5 — integrata

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
react, typescript
Ambito
audio-video-rtc, frontend

Direzione di ricerca

The issue describes the comment players, playback provider, store, registry, and focused browser tests, but gives no file paths. Start by locating the reproduction tests and tracing how inline and mini players release playback claims during removal and handoff. Done means removing a playing comment resumes the main video once, while a main video that started paused remains paused; linked pull request #2797 is already open.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

Playing a video comment pauses the main share-page video. If the comment disappears before finishing, the main video stays paused instead of returning to its previous playing state. Switching the sidebar away from Comments or dismissing a timeline card can remove the player this way.

This affects inline comments, expanded mini players, and removal while the lazy mini player is still loading. A main video that was paused before the comment should stay paused.

Reproduction
  1. Open a share page containing a video comment and start the main video.
  2. Play the video comment in the Comments sidebar. The main video pauses.
  3. Before the comment ends, switch the sidebar to another tab.
  4. The comment disappears, but the main video remains paused. It should resume because it was playing before the comment took over.

The isolated reproduction mounts the actual comment players with the playback provider, store and registry, then removes the comment. It also covers expanding the inline comment and removing its host before the mini player loads.

Same native browser playback fixture Main Fixed
Remove playing inline comment Main stays paused, 0 resume calls Main resumes once
Remove expanded mini player Main stays paused, 0 resume calls Main resumes once
Remove card while mini player loads Main stays paused, 0 resume calls Main resumes once
Main initially paused Stays paused Stays paused
Additional Context
  • Baseline main: 88bce03d6d3ffdf1a23364792599fdf74a92bb77.
  • Chrome 154 on Linux x86_64, React 19.2.4.
  • The browser comparison uses native muted video playback of a synthetic video-only WebM. Comment playback advances before removal. Dialog/control chrome, motion and mini-player loading are fixtures. No authenticated share page, private media or external media service was used.
  • The same 12 focused tests produce 8 failures and 4 passes on main, then all pass after the fix.
  • Both players release their claim from passive cleanup, after React has cleared their video refs. The inline-to-dialog handoff can also clear the outgoing ref before the lazy mini player takes over.
Lingua principale
Rust
Stelle
23.4k
Fork
2.1k
Merge medio
1g 20h
PR unite (30g)
348

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CapSoftware/Cap

Tutte le issue di CapSoftware/Cap

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.