Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Main video stays paused when a playing video comment is removed

Fermée
  • Quelque chose ne va pas ?
#2,796 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Une pull request liée a déjà été fusionnée.

  • #2797 par @AksharP5 — fusionnée

Évaluation

Difficulté
4/5
Temps estimé
1-2 jours
Accessibilité débutants
25/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
react, typescript
Domaine
audio-video-rtc, frontend

Piste de recherche

The issue describes the comment players, playback provider, store, registry, and focused browser tests, but gives no file paths. Start by locating the reproduction tests and tracing how inline and mini players release playback claims during removal and handoff. Done means removing a playing comment resumes the main video once, while a main video that started paused remains paused; linked pull request #2797 is already open.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Description

Playing a video comment pauses the main share-page video. If the comment disappears before finishing, the main video stays paused instead of returning to its previous playing state. Switching the sidebar away from Comments or dismissing a timeline card can remove the player this way.

This affects inline comments, expanded mini players, and removal while the lazy mini player is still loading. A main video that was paused before the comment should stay paused.

Reproduction
  1. Open a share page containing a video comment and start the main video.
  2. Play the video comment in the Comments sidebar. The main video pauses.
  3. Before the comment ends, switch the sidebar to another tab.
  4. The comment disappears, but the main video remains paused. It should resume because it was playing before the comment took over.

The isolated reproduction mounts the actual comment players with the playback provider, store and registry, then removes the comment. It also covers expanding the inline comment and removing its host before the mini player loads.

Same native browser playback fixture Main Fixed
Remove playing inline comment Main stays paused, 0 resume calls Main resumes once
Remove expanded mini player Main stays paused, 0 resume calls Main resumes once
Remove card while mini player loads Main stays paused, 0 resume calls Main resumes once
Main initially paused Stays paused Stays paused
Additional Context
  • Baseline main: 88bce03d6d3ffdf1a23364792599fdf74a92bb77.
  • Chrome 154 on Linux x86_64, React 19.2.4.
  • The browser comparison uses native muted video playback of a synthetic video-only WebM. Comment playback advances before removal. Dialog/control chrome, motion and mini-player loading are fixtures. No authenticated share page, private media or external media service was used.
  • The same 12 focused tests produce 8 failures and 4 passes on main, then all pass after the fix.
  • Both players release their claim from passive cleanup, after React has cleared their video refs. The inline-to-dialog handoff can also clear the outgoing ref before the lazy mini player takes over.
Langage dominant
Rust
Étoiles
23.4k
Forks
2.1k
Merge moyen
2 j 1 h
PR mergées (30 j)
298

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de CapSoftware/Cap

Toutes les issues de CapSoftware/Cap

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.