Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Main video stays paused when a playing video comment is removed

Fechada
  • Algo errado?
#2,796 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Um pull request relacionado já foi integrado.

  • #2797 de @AksharP5 — integrado

Avaliação

Dificuldade
4/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
25/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Estagnada
Stack de tecnologia
react, typescript
Domínio
audio-video-rtc, frontend

Direção de pesquisa

The issue describes the comment players, playback provider, store, registry, and focused browser tests, but gives no file paths. Start by locating the reproduction tests and tracing how inline and mini players release playback claims during removal and handoff. Done means removing a playing comment resumes the main video once, while a main video that started paused remains paused; linked pull request #2797 is already open.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Description

Playing a video comment pauses the main share-page video. If the comment disappears before finishing, the main video stays paused instead of returning to its previous playing state. Switching the sidebar away from Comments or dismissing a timeline card can remove the player this way.

This affects inline comments, expanded mini players, and removal while the lazy mini player is still loading. A main video that was paused before the comment should stay paused.

Reproduction
  1. Open a share page containing a video comment and start the main video.
  2. Play the video comment in the Comments sidebar. The main video pauses.
  3. Before the comment ends, switch the sidebar to another tab.
  4. The comment disappears, but the main video remains paused. It should resume because it was playing before the comment took over.

The isolated reproduction mounts the actual comment players with the playback provider, store and registry, then removes the comment. It also covers expanding the inline comment and removing its host before the mini player loads.

Same native browser playback fixture Main Fixed
Remove playing inline comment Main stays paused, 0 resume calls Main resumes once
Remove expanded mini player Main stays paused, 0 resume calls Main resumes once
Remove card while mini player loads Main stays paused, 0 resume calls Main resumes once
Main initially paused Stays paused Stays paused
Additional Context
  • Baseline main: 88bce03d6d3ffdf1a23364792599fdf74a92bb77.
  • Chrome 154 on Linux x86_64, React 19.2.4.
  • The browser comparison uses native muted video playback of a synthetic video-only WebM. Comment playback advances before removal. Dialog/control chrome, motion and mini-player loading are fixtures. No authenticated share page, private media or external media service was used.
  • The same 12 focused tests produce 8 failures and 4 passes on main, then all pass after the fix.
  • Both players release their claim from passive cleanup, after React has cleared their video refs. The inline-to-dialog handoff can also clear the outgoing ref before the lazy mini player takes over.
Linguagem predominante
Rust
Estrelas
23.4k
Forks
2.1k
Merge médio
1d 19h
PRs com merge (30d)
471

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de CapSoftware/Cap

Todas as issues de CapSoftware/Cap

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.