Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Main video stays paused when a playing video comment is removed

Geschlossen
  • Stimmt etwas nicht?
#2,796 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Ein zugehöriger Pull Request wurde bereits gemerged.

  • #2797 von @AksharP5 — gemerged

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
react, typescript
Bereich
audio-video-rtc, frontend

Rechercherichtung

The issue describes the comment players, playback provider, store, registry, and focused browser tests, but gives no file paths. Start by locating the reproduction tests and tracing how inline and mini players release playback claims during removal and handoff. Done means removing a playing comment resumes the main video once, while a main video that started paused remains paused; linked pull request #2797 is already open.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Description

Playing a video comment pauses the main share-page video. If the comment disappears before finishing, the main video stays paused instead of returning to its previous playing state. Switching the sidebar away from Comments or dismissing a timeline card can remove the player this way.

This affects inline comments, expanded mini players, and removal while the lazy mini player is still loading. A main video that was paused before the comment should stay paused.

Reproduction
  1. Open a share page containing a video comment and start the main video.
  2. Play the video comment in the Comments sidebar. The main video pauses.
  3. Before the comment ends, switch the sidebar to another tab.
  4. The comment disappears, but the main video remains paused. It should resume because it was playing before the comment took over.

The isolated reproduction mounts the actual comment players with the playback provider, store and registry, then removes the comment. It also covers expanding the inline comment and removing its host before the mini player loads.

Same native browser playback fixture Main Fixed
Remove playing inline comment Main stays paused, 0 resume calls Main resumes once
Remove expanded mini player Main stays paused, 0 resume calls Main resumes once
Remove card while mini player loads Main stays paused, 0 resume calls Main resumes once
Main initially paused Stays paused Stays paused
Additional Context
  • Baseline main: 88bce03d6d3ffdf1a23364792599fdf74a92bb77.
  • Chrome 154 on Linux x86_64, React 19.2.4.
  • The browser comparison uses native muted video playback of a synthetic video-only WebM. Comment playback advances before removal. Dialog/control chrome, motion and mini-player loading are fixtures. No authenticated share page, private media or external media service was used.
  • The same 12 focused tests produce 8 failures and 4 passes on main, then all pass after the fix.
  • Both players release their claim from passive cleanup, after React has cleared their video refs. The inline-to-dialog handoff can also clear the outgoing ref before the lazy mini player takes over.
Vorherrschende Sprache
Rust
Sterne
23.4k
Forks
2.1k
Ø Merge
1 T. 20 Std.
Gemergte PRs (30 T.)
348

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus CapSoftware/Cap

Alle Issues in CapSoftware/Cap

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.