P3: scene-render framing appears ~10px high vs Arcentry reference (shift down raises fidelity)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- react, typescript
Research direction
Start in packages/editor-2.5d-react/src/iso/scene-render.test.ts, where REFERENCE_ZOOM and the frozen camera are set, and check how tests/scene.json feeds the render. Sweep a small vertical camera offset and compare scores against tests/snapshots/reference-canvas.png. Done means a better-scoring offset is recorded with pnpm visual:record and the existing visual tests still pass.
Written by the indexing model from the issue text.
Description
Found while reviewing #84 (rescored fidelity metric, pre-existing under the old metric too).
Shifting the current scene-render output 10 px down raises the Arcentry fidelity score against tests/snapshots/reference-canvas.png:
| image | new metric (#84) | old metric |
|---|---|---|
| current render (darwin, chromium-1217) | 0.16487 | 0.283 |
| render shifted (0, +10) | 0.16805 | 0.29214 |
| render shifted (+10, 0) | 0.10263 | 0.23462 |
All other degradations probed (shift +3/+30, zoom 0.95/1.02, erasing a part) score lower, so the metric does discriminate. This result suggests our framing sits a few pixels above Arcentry's, a cheap fidelity gain for M2 Arcentry parity.
Where: packages/editor-2.5d-react/src/iso/scene-render.test.ts (REFERENCE_ZOOM / frozen camera) and tests/scene.json.
Fix: sweep a vertical camera/pan offset of a few pixels, take the best score, and record it with pnpm visual:record.
🤖 Generated with Claude Code
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 10h 39m
- Merged PRs (30d)
- 38
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
hyperdrive-technology/holodeck#196 ·
Maintainers usually reply within 1 day
-
area:docs review-finding
Difficulty 1/5 Under an hour Newbie friendliness 70/100
hyperdrive-technology/holodeck#180 ·
Maintainers usually reply within 1 day
-
Flaky E3 test: native cut with no keydown (holodeck#123) in editing-ux-render.test.tsPossibly taken @dezlitz claimed this today. Openarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hyperdrive-technology/holodeck#141 ·
Maintainers usually reply within 1 day
-
assetUrlProblem: data:image check uses the un-normalised URL, so ' data:image/png...' is rejectedOpenarea:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hyperdrive-technology/holodeck#104 ·
Maintainers usually reply within 1 day
-
agent area:holodeck good first issue priority:p2
Difficulty 1/5 Under an hour Newbie friendliness 72/100
hyperdrive-technology/holodeck#64 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
"Contains" page watch never matches when its text has a trailing spacePossibly taken @RaphaelFakhri claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
CopilotKit/openmuse#184 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
bootstrap-vue-next/bootstrap-vue-next#3357 ·
Maintainers usually reply within 1 day
-
[quality] tide.ts: six mutation survivors in the merge-queue gate, draft refusal, fork-403 workflow-file diagnosis and getPull's fork flag are unpinned by any testPossibly taken @hivecommons-hive claimed this today. Openagent/quality needs-kind stage/040-covered-by-pr testing
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
cncf/prow-github-actions#517 · 1 comment ·
Maintainers usually reply within 2 days
-
Unsampled pageload span is profiled when profileLifecycle is 'trace' (browser UI profiling)Possibly taken @Jxxunnn claimed this today. OpenBrowser Waiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
getsentry/sentry-javascript#25497 · 1 comment ·
Maintainers usually reply within 1 day