Review player: show clicks and captions on the timeline

Ouverte
#378 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
57/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript

Piste de recherche

Start with src/tools/reviewRecording.ts to see how player_frames builds its payload, then read assets/ui/player.js for the timeline and frame display. Check src/utils/events.ts, src/tools/readEvents.ts, and src/tools/transcribe.ts for the event log and SRT sidecar formats. Done means both tracks can be toggled, clicks seek and show their frame position, captions follow the current frame and can seek, and a 10k-event log keeps the payload bounded.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

effort: medium enhancement help wanted priority: medium

Summary

The review player's timeline shows scene changes and markers, but not what happened: no clicks or keystrokes from the event log, and no captions. Finding "the moment after the Save click" means scrubbing frame by frame, even when the server already knows when every click happened.

Where

  • src/tools/reviewRecording.ts:51-53, 106 (player data carries markers only)
  • assets/ui/player.js:118-143 (renders scene ticks and markers only)
  • src/utils/events.ts, src/tools/readEvents.ts (event log on the video clock)
  • src/tools/transcribe.ts (SRT sidecar)

Suggested fix

  • Include a compact clicks list (t, button, x/y, and the UI element name from #333 when present) and captions (t, end, text) in the player_frames result when the sidecars exist. Cap the counts.
  • Draw click ticks as a second row under the timeline. Hovering or focusing one shows a crosshair on the frame at the click point.
  • Show the caption for the current frame under the stage, and make caption lines clickable to seek.
  • Both tracks can be toggled off.

Acceptance criteria

  • Recordings with an event log show click ticks that seek on activation
  • Recordings with an SRT show the current caption
  • Recordings without sidecars look the same as today
  • Payload stays bounded (test with a 10k-event log)

Getting started

  • Relevant files: src/tools/reviewRecording.ts, assets/ui/player.js, src/utils/events.ts

Filed by repo-audit/feature-ideas at 1ac339f. Severity: medium. Effort: M. audit-key: enhancement|src/tools/reviewRecording.ts|tracks

Langage dominant
TypeScript
Étoiles
1
Forks
4
Merge moyen
8 h 17 min
PR mergées (30 j)
46

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/screencast-mcp

Toutes les issues de TMHSDigital/screencast-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.