MAINT Extract scenario-history aggregate queries and record construction
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 35/100
Línea de trabajo
Wait for #2766 and #2768 to land before starting. Then read pyrit/memory/memory_interface.py and the scenario-history entry points, followed by tests/unit/memory/memory_interface/test_interface_scenario_history.py and tests/unit/backend/test_scenario_run_service.py. Done means the public delegate and return shape remain unchanged, aggregation stays database-side, and the existing history coverage passes with database portability preserved.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Is your feature request related to a problem? Please describe.
MemoryInterface.get_scenario_history_aggregates() and _build_scenario_history_aggregate_statement() combine SQL aggregation, retry/error accounting, latest-attempt selection, auxiliary name lookup, and typed aggregate-record construction. After page retrieval and attempt-to-work-unit matching have been extracted, these are the remaining core history-query responsibilities in the general memory interface.
This is M3 of three scenario-history extraction steps. Not ready yet: depends on #2768, after #2766. Wait for those boundaries to land, then move aggregation into the same internal query module and reassess readiness before adding help wanted.
Describe the solution you'd like
Extract history aggregate statement construction, execution, and row-to-ScenarioHistoryAggregate conversion. Use the matching logic from #2768 rather than duplicating it, and retain the public MemoryInterface.get_scenario_history_aggregates() method as a delegate.
- Preserve grouping by logical work unit, the existing latest-attempt ordering, and all success/completion/error/retry arithmetic.
- Keep aggregation database-side, with compact result rows and the existing backend-specific expression hooks.
- Preserve empty/default records for requested runs with no matching attempts and the existing sorted attack-name output.
- Finish wiring the page method from #2766 through the cohesive internal history-query implementation without changing its return shape.
- Keep legacy/unusable-plan handling and caller policy in their existing layers. Do not redesign the backend service or GUI.
Acceptance criteria:
- Public signatures and typed return values remain unchanged.
- Runs with no attempts retain their zero/default aggregates; empty input is handled as before.
- Repeated attempts, internal retries, error attempts, and transitions between success/error outcomes produce exactly the existing counters.
- Tied timestamps retain the ID tiebreaker; latest timestamps, sorted attack names, and mixed planned/legacy results remain unchanged.
- Runs outside a usable plan keep existing fallback behavior, while unmatched planned attempts remain excluded from counters.
- No full result-object hydration, Python-side replacement of SQL aggregation, or new per-run/per-attempt query loop is introduced.
- Existing memory and backend history coverage exercises the final delegated path and guards database portability.
Describe alternatives you've considered, if relevant
Do not combine this with new counter semantics, a schema migration, or broad extraction of all scenario persistence methods. Do not make a separate service for each extraction step. The intended result is one cohesive private query component reached through the existing memory API.
Additional context
Starting points: pyrit/memory/memory_interface.py, get_scenario_history_aggregates, _build_scenario_history_aggregate_statement, and the page entry point. Coverage: tests/unit/memory/memory_interface/test_interface_scenario_history.py and tests/unit/backend/test_scenario_run_service.py.
Series: #2766 (history pages), #2768 (attempt matching), then this issue (aggregate queries/records). Follow doc/code/framework.md and the applicable database, Python, and test instructions. Memory owns retrieval and database aggregation here, not scenario execution, scoring decisions, or presentation.
- Lenguaje dominante
- Python
- Estrellas
- 4.5k
- Forks
- 896
- Merge medio
- 3 d 8 h
- PR fusionados (30 d)
- 191
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de microsoft/PyRIT
-
Dificultad 3/5 1-2 días Aptitud para principiantes 65/100
-
Bug: triage GUI help wanted
Dificultad 3/5 1-2 días Aptitud para principiantes 65/100
-
feature-request
Dificultad 3/5 1-2 días Aptitud para principiantes 70/100
-
bug help wanted
Dificultad 4/5 3-5 días Aptitud para principiantes 68/100
-
not ready yet
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
Todos los issues de microsoft/PyRIT
Issues similares
-
bug confirmed issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
open-webui/open-webui#30750 · 1 comentario ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · 1 comentario ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
good first issue
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100