MAINT Extract scenario-history aggregate queries and record construction
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 35/100
調査の方向性
Wait for #2766 and #2768 to land before starting. Then read pyrit/memory/memory_interface.py and the scenario-history entry points, followed by tests/unit/memory/memory_interface/test_interface_scenario_history.py and tests/unit/backend/test_scenario_run_service.py. Done means the public delegate and return shape remain unchanged, aggregation stays database-side, and the existing history coverage passes with database portability preserved.
索引モデルが issue の本文から書いたものです。
説明
Is your feature request related to a problem? Please describe.
MemoryInterface.get_scenario_history_aggregates() and _build_scenario_history_aggregate_statement() combine SQL aggregation, retry/error accounting, latest-attempt selection, auxiliary name lookup, and typed aggregate-record construction. After page retrieval and attempt-to-work-unit matching have been extracted, these are the remaining core history-query responsibilities in the general memory interface.
This is M3 of three scenario-history extraction steps. Not ready yet: depends on #2768, after #2766. Wait for those boundaries to land, then move aggregation into the same internal query module and reassess readiness before adding help wanted.
Describe the solution you'd like
Extract history aggregate statement construction, execution, and row-to-ScenarioHistoryAggregate conversion. Use the matching logic from #2768 rather than duplicating it, and retain the public MemoryInterface.get_scenario_history_aggregates() method as a delegate.
- Preserve grouping by logical work unit, the existing latest-attempt ordering, and all success/completion/error/retry arithmetic.
- Keep aggregation database-side, with compact result rows and the existing backend-specific expression hooks.
- Preserve empty/default records for requested runs with no matching attempts and the existing sorted attack-name output.
- Finish wiring the page method from #2766 through the cohesive internal history-query implementation without changing its return shape.
- Keep legacy/unusable-plan handling and caller policy in their existing layers. Do not redesign the backend service or GUI.
Acceptance criteria:
- Public signatures and typed return values remain unchanged.
- Runs with no attempts retain their zero/default aggregates; empty input is handled as before.
- Repeated attempts, internal retries, error attempts, and transitions between success/error outcomes produce exactly the existing counters.
- Tied timestamps retain the ID tiebreaker; latest timestamps, sorted attack names, and mixed planned/legacy results remain unchanged.
- Runs outside a usable plan keep existing fallback behavior, while unmatched planned attempts remain excluded from counters.
- No full result-object hydration, Python-side replacement of SQL aggregation, or new per-run/per-attempt query loop is introduced.
- Existing memory and backend history coverage exercises the final delegated path and guards database portability.
Describe alternatives you've considered, if relevant
Do not combine this with new counter semantics, a schema migration, or broad extraction of all scenario persistence methods. Do not make a separate service for each extraction step. The intended result is one cohesive private query component reached through the existing memory API.
Additional context
Starting points: pyrit/memory/memory_interface.py, get_scenario_history_aggregates, _build_scenario_history_aggregate_statement, and the page entry point. Coverage: tests/unit/memory/memory_interface/test_interface_scenario_history.py and tests/unit/backend/test_scenario_run_service.py.
Series: #2766 (history pages), #2768 (attempt matching), then this issue (aggregate queries/records). Follow doc/code/framework.md and the applicable database, Python, and test instructions. Memory owns retrieval and database aggregation here, not scenario execution, scoring decisions, or presentation.
- 主要言語
- Python
- スター
- 4.5k
- フォーク
- 896
- 平均マージ
- 3日 8時間
- マージ済み PR(30日)
- 191
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
microsoft/PyRIT のほかの issue
-
難易度 3/5 1〜2日 初心者へのやさしさ 65/100
-
Bug: triage GUI help wanted
難易度 3/5 1〜2日 初心者へのやさしさ 65/100
-
feature-request
難易度 3/5 1〜2日 初心者へのやさしさ 70/100
-
bug help wanted
難易度 4/5 3〜5日 初心者へのやさしさ 68/100
-
not ready yet
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
microsoft/PyRIT の issue をすべて見る
似ている issue
-
bug confirmed issue
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
open-webui/open-webui#30750 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
-
good first issue
難易度 1/5 1時間未満 初心者へのやさしさ 90/100