Content writes have no default item cap, no hook timeout, and an idempotency lease that is never renewed

Abierto
#3,307 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp

Línea de trabajo

Start with the cited files under src/FluentCMS.Core/: Schema/FieldTypes/FieldLengths.cs, Content/Validation/DeclarativeValidator.cs, Content/Hooks/HookPipeline.cs, and Idempotency/IdempotencyStore.cs. Read the related spec and trace how field limits, hook execution, and idempotency leases are handled; then find the existing tests for each area. Done means all three acceptance cases pass, with tests covering them.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:content type:bug

Problem

  1. Multiple-value fields have no default item cap. Schema/FieldTypes/FieldLengths.cs:18-19 gives them no default and Content/Validation/DeclarativeValidator.cs:106 checks only a declared maximum. Over HTTP the 2 MiB body is the bound; SDK calls and imports have none.
  2. A hook can hold the write transaction without limit. Hooks run inside it by design (spec line 684), but there is no hook timeout (Content/Hooks/HookPipeline.cs:98-108), and SQLite takes the write lock at begin (Content/ContentService.cs:546).
  3. A write can run twice under one idempotency key. The claim itself is safe (Idempotency/IdempotencyStore.cs:66-95,125-133), but the 5-minute lease is never renewed (Idempotency/IdempotencyOptions.cs:17). A handler that runs longer, or a retry after a client abort (Api/Common/IdempotentRequests.cs:44-49), can take the key over while the first run is still working.

Paths are under src/FluentCMS.Core/.

Proposal

  • A default cap of 1,000 items for multiple and blocks fields; a declared maximum overrides it.
  • A configurable hook timeout and a warning that names a slow hook.
  • Renew the lease while the handler runs.

Acceptance

  • A value with more than 1,000 items is refused unless the field declares a higher maximum
  • A hook over the timeout fails the write with a problem naming the hook
  • A handler that runs longer than the lease is not run a second time under its key
  • Tests for each

Found in the code review of 17 Nov 2026.

Lenguaje dominante
C#
Estrellas
567
Forks
107
Merge medio
1 h 19 min
PR fusionados (30 d)
353

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.