Content writes have no default item cap, no hook timeout, and an idempotency lease that is never renewed

Offen
#3,307 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
35/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
csharp

Rechercherichtung

Start with the cited files under src/FluentCMS.Core/: Schema/FieldTypes/FieldLengths.cs, Content/Validation/DeclarativeValidator.cs, Content/Hooks/HookPipeline.cs, and Idempotency/IdempotencyStore.cs. Read the related spec and trace how field limits, hook execution, and idempotency leases are handled; then find the existing tests for each area. Done means all three acceptance cases pass, with tests covering them.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:content type:bug

Problem

  1. Multiple-value fields have no default item cap. Schema/FieldTypes/FieldLengths.cs:18-19 gives them no default and Content/Validation/DeclarativeValidator.cs:106 checks only a declared maximum. Over HTTP the 2 MiB body is the bound; SDK calls and imports have none.
  2. A hook can hold the write transaction without limit. Hooks run inside it by design (spec line 684), but there is no hook timeout (Content/Hooks/HookPipeline.cs:98-108), and SQLite takes the write lock at begin (Content/ContentService.cs:546).
  3. A write can run twice under one idempotency key. The claim itself is safe (Idempotency/IdempotencyStore.cs:66-95,125-133), but the 5-minute lease is never renewed (Idempotency/IdempotencyOptions.cs:17). A handler that runs longer, or a retry after a client abort (Api/Common/IdempotentRequests.cs:44-49), can take the key over while the first run is still working.

Paths are under src/FluentCMS.Core/.

Proposal

  • A default cap of 1,000 items for multiple and blocks fields; a declared maximum overrides it.
  • A configurable hook timeout and a warning that names a slow hook.
  • Renew the lease while the handler runs.

Acceptance

  • A value with more than 1,000 items is refused unless the field declares a higher maximum
  • A hook over the timeout fails the write with a problem naming the hook
  • A handler that runs longer than the lease is not run a second time under its key
  • Tests for each

Found in the code review of 17 Nov 2026.

Vorherrschende Sprache
C#
Sterne
567
Forks
107
Ø Merge
1 Std. 19 Min.
Gemergte PRs (30 T.)
353

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus fluentcms/FluentCMS

Alle Issues in fluentcms/FluentCMS

Ähnliche Issues

Weitere Issues zu C#

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.