WebhookClaimTests.TwoJobsForOneAttemptSendOnceAndRecordOneRow fails now and then on CI

Abierto
#3,475 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp
Área
testing

Línea de trabajo

Start with WebhookClaimTests.cs:85 and trace how the two jobs are claimed and scheduled around host.Time.Advance(Abandoned). Identify what state the second job needs before the clock advances, then make the test wait for that state instead of relying on worker order or timing. Run WebhookClaimTests.TwoJobsForOneAttemptSendOnceAndRecordOneRow and confirm it passes reliably.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:testing type:bug

Problem

FluentCMS.Plugins.Webhooks.Tests.WebhookClaimTests.TwoJobsForOneAttemptSendOnceAndRecordOneRow failed twice on 20 Nov 2026, in two runs that change nothing of the webhooks plugin:

  • the push run on main for 4b5ff6e1 (#3466, test helpers of the PostgreSQL data tests), run 44832337315, attempt 1; it passed on the rerun of the failed jobs;
  • the pull request #3471 (workflows only), run 44834414057, job Tests (plugins-1).

Both times it is WebhookClaimTests.cs:85, Shouldly.ShouldAssertException : 0 should be 1: after host.Time.Advance(Abandoned), RunDueJobsAsync finds no due job, where the test expects the second job to wait until the claim it found would be abandoned and then run.

Proposal

Find what the second job's schedule depends on besides the fake clock (a real delay, the order in which the two workers took their jobs, a claim written after the clock moved), and make the test wait for the state it needs before it moves the clock.

Acceptance

  • The cause is named
  • The test no longer depends on the order or timing of the two workers

For workstation B (#3356). Seen by A.

Lenguaje dominante
C#
Estrellas
567
Forks
107
Merge medio
1 h 19 min
PR fusionados (30 d)
353

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.