Content writes have no default item cap, no hook timeout, and an idempotency lease that is never renewed

Aperta
#3,307 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp

Direzione di ricerca

Start with the cited files under src/FluentCMS.Core/: Schema/FieldTypes/FieldLengths.cs, Content/Validation/DeclarativeValidator.cs, Content/Hooks/HookPipeline.cs, and Idempotency/IdempotencyStore.cs. Read the related spec and trace how field limits, hook execution, and idempotency leases are handled; then find the existing tests for each area. Done means all three acceptance cases pass, with tests covering them.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:content type:bug

Problem

  1. Multiple-value fields have no default item cap. Schema/FieldTypes/FieldLengths.cs:18-19 gives them no default and Content/Validation/DeclarativeValidator.cs:106 checks only a declared maximum. Over HTTP the 2 MiB body is the bound; SDK calls and imports have none.
  2. A hook can hold the write transaction without limit. Hooks run inside it by design (spec line 684), but there is no hook timeout (Content/Hooks/HookPipeline.cs:98-108), and SQLite takes the write lock at begin (Content/ContentService.cs:546).
  3. A write can run twice under one idempotency key. The claim itself is safe (Idempotency/IdempotencyStore.cs:66-95,125-133), but the 5-minute lease is never renewed (Idempotency/IdempotencyOptions.cs:17). A handler that runs longer, or a retry after a client abort (Api/Common/IdempotentRequests.cs:44-49), can take the key over while the first run is still working.

Paths are under src/FluentCMS.Core/.

Proposal

  • A default cap of 1,000 items for multiple and blocks fields; a declared maximum overrides it.
  • A configurable hook timeout and a warning that names a slow hook.
  • Renew the lease while the handler runs.

Acceptance

  • A value with more than 1,000 items is refused unless the field declares a higher maximum
  • A hook over the timeout fails the write with a problem naming the hook
  • A handler that runs longer than the lease is not run a second time under its key
  • Tests for each

Found in the code review of 17 Nov 2026.

Lingua principale
C#
Stelle
567
Fork
107
Merge medio
1h 19m
PR unite (30g)
353

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fluentcms/FluentCMS

Tutte le issue di fluentcms/FluentCMS

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.