Content writes have no default item cap, no hook timeout, and an idempotency lease that is never renewed

Ouverte
#3,307 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
35/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
csharp

Piste de recherche

Start with the cited files under src/FluentCMS.Core/: Schema/FieldTypes/FieldLengths.cs, Content/Validation/DeclarativeValidator.cs, Content/Hooks/HookPipeline.cs, and Idempotency/IdempotencyStore.cs. Read the related spec and trace how field limits, hook execution, and idempotency leases are handled; then find the existing tests for each area. Done means all three acceptance cases pass, with tests covering them.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:content type:bug

Problem

  1. Multiple-value fields have no default item cap. Schema/FieldTypes/FieldLengths.cs:18-19 gives them no default and Content/Validation/DeclarativeValidator.cs:106 checks only a declared maximum. Over HTTP the 2 MiB body is the bound; SDK calls and imports have none.
  2. A hook can hold the write transaction without limit. Hooks run inside it by design (spec line 684), but there is no hook timeout (Content/Hooks/HookPipeline.cs:98-108), and SQLite takes the write lock at begin (Content/ContentService.cs:546).
  3. A write can run twice under one idempotency key. The claim itself is safe (Idempotency/IdempotencyStore.cs:66-95,125-133), but the 5-minute lease is never renewed (Idempotency/IdempotencyOptions.cs:17). A handler that runs longer, or a retry after a client abort (Api/Common/IdempotentRequests.cs:44-49), can take the key over while the first run is still working.

Paths are under src/FluentCMS.Core/.

Proposal

  • A default cap of 1,000 items for multiple and blocks fields; a declared maximum overrides it.
  • A configurable hook timeout and a warning that names a slow hook.
  • Renew the lease while the handler runs.

Acceptance

  • A value with more than 1,000 items is refused unless the field declares a higher maximum
  • A hook over the timeout fails the write with a problem naming the hook
  • A handler that runs longer than the lease is not run a second time under its key
  • Tests for each

Found in the code review of 17 Nov 2026.

Langage dominant
C#
Étoiles
567
Forks
107
Merge moyen
1 h 19 min
PR mergées (30 j)
353

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de fluentcms/FluentCMS

Toutes les issues de fluentcms/FluentCMS

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.