[Testing] Match terminal checkpoint response semantics

Abierto
  • ¿Algo no está bien?
#773 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
backend

Línea de trabajo

Start in checkpoint/core.py around lines 128-171, where the checkpoint token and operation delta are computed, then compare the two callers in executor.py (1020-1043) and checkpoint/processor.py (118-139). The SDK's tokenless-completion branch in state.py (1065-1075) shows the expected terminal behavior. Done means terminal SUCCEED and FAIL batches return no token and empty operations through both entry points, with tests for non-terminal batches unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

parity pkg:testing
Expected behavior

When an accepted checkpoint batch completes an execution, the emulator should return no checkpoint token and an empty Operations list. This should cover both execution success and execution failure.

This service behavior is documented in the PR #757 review discussion. The emulator findings below are confirmed by source inspection; no service response trace is included in this report.

Actual behavior

The shared checkpoint core can return a newly generated token and an unseen operation delta even when the accepted batch completes the execution. See checkpoint/core.py:128–171.

Both checkpoint entry points compute that result before applying completion or failure effects:

So terminal-response detection must account for the accepted batch, rather than rely only on execution status before those effects run.

The SDK distinguishes tokenless execution completion from token withdrawal in state.py:1065–1075. Ordinary terminal checkpoints against the emulator do not exercise the tokenless-completion branch.

Reproduction scenario
  1. Start an execution with a valid invocation and checkpoint token.
  2. Submit an accepted batch containing an EXECUTION update with action SUCCEED.
  3. Observe that the response still contains a checkpoint token.
  4. Repeat with EXECUTION/FAIL.
  5. Include unseen operation changes to demonstrate that the terminal response can also return a nonempty operations list.

This scenario follows from source inspection at revision 52b63b5f; it has not been executed for this report.

Acceptance criteria
  • Cover terminal success and failure through both checkpoint entry points.
  • Return no checkpoint token and empty operations for terminal batches.
  • Cover terminal batches with otherwise-returnable operation changes.
  • Preserve accepted updates and completion/failure effects, including the result or error.
  • Add SDK/emulator integration coverage that verifies terminal completion rather than PENDING or unnecessary reinvocation.
  • Preserve existing behavior for non-terminal checkpoint batches.
Lenguaje dominante
Python
Estrellas
58
Forks
32
Merge medio
1 d 6 h
PR fusionados (30 d)
80

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de aws/aws-durable-execution-sdk-python

Todos los issues de aws/aws-durable-execution-sdk-python

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.