[Testing] Match terminal checkpoint response semantics

未关闭
  • 哪里不对？
#773 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
backend

调研方向

Start in checkpoint/core.py around lines 128-171, where the checkpoint token and operation delta are computed, then compare the two callers in executor.py (1020-1043) and checkpoint/processor.py (118-139). The SDK's tokenless-completion branch in state.py (1065-1075) shows the expected terminal behavior. Done means terminal SUCCEED and FAIL batches return no token and empty operations through both entry points, with tests for non-terminal batches unchanged.

由索引模型根据 Issue 内容生成。

描述

parity pkg:testing
Expected behavior

When an accepted checkpoint batch completes an execution, the emulator should return no checkpoint token and an empty Operations list. This should cover both execution success and execution failure.

This service behavior is documented in the PR #757 review discussion. The emulator findings below are confirmed by source inspection; no service response trace is included in this report.

Actual behavior

The shared checkpoint core can return a newly generated token and an unseen operation delta even when the accepted batch completes the execution. See checkpoint/core.py:128–171.

Both checkpoint entry points compute that result before applying completion or failure effects:

So terminal-response detection must account for the accepted batch, rather than rely only on execution status before those effects run.

The SDK distinguishes tokenless execution completion from token withdrawal in state.py:1065–1075. Ordinary terminal checkpoints against the emulator do not exercise the tokenless-completion branch.

Reproduction scenario
  1. Start an execution with a valid invocation and checkpoint token.
  2. Submit an accepted batch containing an EXECUTION update with action SUCCEED.
  3. Observe that the response still contains a checkpoint token.
  4. Repeat with EXECUTION/FAIL.
  5. Include unseen operation changes to demonstrate that the terminal response can also return a nonempty operations list.

This scenario follows from source inspection at revision 52b63b5f; it has not been executed for this report.

Acceptance criteria
  • Cover terminal success and failure through both checkpoint entry points.
  • Return no checkpoint token and empty operations for terminal batches.
  • Cover terminal batches with otherwise-returnable operation changes.
  • Preserve accepted updates and completion/failure effects, including the result or error.
  • Add SDK/emulator integration coverage that verifies terminal completion rather than PENDING or unnecessary reinvocation.
  • Preserve existing behavior for non-terminal checkpoint batches.
主要语言
Python
星标
58
派生
32
平均合并
1 天 6 小时
30 天内合并 PR
80

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

aws/aws-durable-execution-sdk-python 的其他 Issue

查看 aws/aws-durable-execution-sdk-python 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。