[Testing] Match terminal checkpoint response semantics

Offen
  • Stimmt etwas nicht?
#773 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
python
Bereich
backend

Rechercherichtung

Start in checkpoint/core.py around lines 128-171, where the checkpoint token and operation delta are computed, then compare the two callers in executor.py (1020-1043) and checkpoint/processor.py (118-139). The SDK's tokenless-completion branch in state.py (1065-1075) shows the expected terminal behavior. Done means terminal SUCCEED and FAIL batches return no token and empty operations through both entry points, with tests for non-terminal batches unchanged.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

parity pkg:testing
Expected behavior

When an accepted checkpoint batch completes an execution, the emulator should return no checkpoint token and an empty Operations list. This should cover both execution success and execution failure.

This service behavior is documented in the PR #757 review discussion. The emulator findings below are confirmed by source inspection; no service response trace is included in this report.

Actual behavior

The shared checkpoint core can return a newly generated token and an unseen operation delta even when the accepted batch completes the execution. See checkpoint/core.py:128–171.

Both checkpoint entry points compute that result before applying completion or failure effects:

So terminal-response detection must account for the accepted batch, rather than rely only on execution status before those effects run.

The SDK distinguishes tokenless execution completion from token withdrawal in state.py:1065–1075. Ordinary terminal checkpoints against the emulator do not exercise the tokenless-completion branch.

Reproduction scenario
  1. Start an execution with a valid invocation and checkpoint token.
  2. Submit an accepted batch containing an EXECUTION update with action SUCCEED.
  3. Observe that the response still contains a checkpoint token.
  4. Repeat with EXECUTION/FAIL.
  5. Include unseen operation changes to demonstrate that the terminal response can also return a nonempty operations list.

This scenario follows from source inspection at revision 52b63b5f; it has not been executed for this report.

Acceptance criteria
  • Cover terminal success and failure through both checkpoint entry points.
  • Return no checkpoint token and empty operations for terminal batches.
  • Cover terminal batches with otherwise-returnable operation changes.
  • Preserve accepted updates and completion/failure effects, including the result or error.
  • Add SDK/emulator integration coverage that verifies terminal completion rather than PENDING or unnecessary reinvocation.
  • Preserve existing behavior for non-terminal checkpoint batches.
Vorherrschende Sprache
Python
Sterne
58
Forks
32
Ø Merge
1 T. 6 Std.
Gemergte PRs (30 T.)
80

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus aws/aws-durable-execution-sdk-python

Alle Issues in aws/aws-durable-execution-sdk-python

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.