[Testing] Match terminal checkpoint response semantics

Aperta
  • Qualcosa non va?
#773 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend

Direzione di ricerca

Start in checkpoint/core.py around lines 128-171, where the checkpoint token and operation delta are computed, then compare the two callers in executor.py (1020-1043) and checkpoint/processor.py (118-139). The SDK's tokenless-completion branch in state.py (1065-1075) shows the expected terminal behavior. Done means terminal SUCCEED and FAIL batches return no token and empty operations through both entry points, with tests for non-terminal batches unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

parity pkg:testing
Expected behavior

When an accepted checkpoint batch completes an execution, the emulator should return no checkpoint token and an empty Operations list. This should cover both execution success and execution failure.

This service behavior is documented in the PR #757 review discussion. The emulator findings below are confirmed by source inspection; no service response trace is included in this report.

Actual behavior

The shared checkpoint core can return a newly generated token and an unseen operation delta even when the accepted batch completes the execution. See checkpoint/core.py:128–171.

Both checkpoint entry points compute that result before applying completion or failure effects:

So terminal-response detection must account for the accepted batch, rather than rely only on execution status before those effects run.

The SDK distinguishes tokenless execution completion from token withdrawal in state.py:1065–1075. Ordinary terminal checkpoints against the emulator do not exercise the tokenless-completion branch.

Reproduction scenario
  1. Start an execution with a valid invocation and checkpoint token.
  2. Submit an accepted batch containing an EXECUTION update with action SUCCEED.
  3. Observe that the response still contains a checkpoint token.
  4. Repeat with EXECUTION/FAIL.
  5. Include unseen operation changes to demonstrate that the terminal response can also return a nonempty operations list.

This scenario follows from source inspection at revision 52b63b5f; it has not been executed for this report.

Acceptance criteria
  • Cover terminal success and failure through both checkpoint entry points.
  • Return no checkpoint token and empty operations for terminal batches.
  • Cover terminal batches with otherwise-returnable operation changes.
  • Preserve accepted updates and completion/failure effects, including the result or error.
  • Add SDK/emulator integration coverage that verifies terminal completion rather than PENDING or unnecessary reinvocation.
  • Preserve existing behavior for non-terminal checkpoint batches.
Lingua principale
Python
Stelle
58
Fork
32
Merge medio
1g 6h
PR unite (30g)
80

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aws/aws-durable-execution-sdk-python

Tutte le issue di aws/aws-durable-execution-sdk-python

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.