Controlled report: a rejected change is not told apart from a late echo, the next step carries it

Open
#317 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
javascript, react

Research direction

Start with useViewHistory in packages/pivotkit-react/src/use-view-history.js and trace how echo.pending, waiting, and live handle views passed through onViewChange. Read the existing late-echo coverage for issue #141 and the cap work in #204, then review the host test page and reference/react.md and the element's events. Done means a host can explicitly reject a change, with tests and docs showing that the next change starts from the host's displayed view.

Written by the indexing model from the issue text.

Description

area:react idea

A controlled report cannot tell a host that rejects a change from one that passes it back late, so after a rejected change the next step builds on the report's own history instead of the view the host shows.

Where: useViewHistory in use-view-history.js. While echo.pending holds views the host was told through onViewChange and has not passed back, waiting is true and live is the report's own history, not the view shown. A host that rejects a change keeps passing its old view, so the report keeps waiting.

Example: the host rejects "add Region". The user then adds Country. The report sends Region and Country with the second onViewChange; a host that accepts that one gets Region as well.

Not affected: hosts that pass every view back, early or late (#141), and uncontrolled reports. The list of waiting views no longer grows without end (capped in #204).

Why this needs a decision: the report sees the same view prop either way. A host that answers late re-renders with its old view in between (the test host does every 200 ms, with the same object), and hosts that build view anew on every render would give a new object each time, so neither the key nor the object identity tells a rejection apart. The host has to say it.

Proposal: a documented way to reject, for example onViewChange returning false (the view stays, nothing waits for it), or a host passing a new copy of its view after a change it rejects. The first is explicit and needs no guess about render timing; both need a host test page case and docs in reference/react.md and the element's events.

Dominant language
JavaScript
Stars
1
Forks
1
Avg merge
3h 21m
Merged PRs (30d)
250

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eizedev/pivotkit

All issues in eizedev/pivotkit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.