test: remove the Firefox file chooser workaround once Playwright fixes #44143

Open Beginner friendly
#572 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript, playwright
Domain
frontend, testing

Research direction

Read tests/browser/import-helpers.js and inspect nextFileChooser, then check whether microsoft/playwright#44143 has been fixed and released. If it has, upgrade Playwright, remove the no-op listener while keeping the helper or using page.waitForEvent, and repeat import.spec.js:428 40 times in Firefox with 8 workers to confirm the workaround is no longer needed.

Written by the indexing model from the issue text.

Description

area:tests

pivotkit's browser tests keep one no-op filechooser listener per page (nextFileChooser in tests/browser/import-helpers.js) to work around microsoft/playwright#44143: with Firefox in Playwright 1.65, the second file chooser in a test sometimes opens the native picker instead of firing the event.

When the upstream issue is fixed and released, upgrade Playwright, remove the listener from nextFileChooser (keep the helper or go back to page.waitForEvent), and confirm with import.spec.js:428 repeated 40 times in Firefox with 8 workers.

Dominant language
JavaScript
Stars
1
Forks
1
Avg merge
3h 21m
Merged PRs (30d)
250

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eizedev/pivotkit

All issues in eizedev/pivotkit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.