test: remove the Firefox file chooser workaround once Playwright fixes #44143
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, playwright
Research direction
Read tests/browser/import-helpers.js and inspect nextFileChooser, then check whether microsoft/playwright#44143 has been fixed and released. If it has, upgrade Playwright, remove the no-op listener while keeping the helper or using page.waitForEvent, and repeat import.spec.js:428 40 times in Firefox with 8 workers to confirm the workaround is no longer needed.
Written by the indexing model from the issue text.
Description
pivotkit's browser tests keep one no-op filechooser listener per page (nextFileChooser in tests/browser/import-helpers.js) to work around microsoft/playwright#44143: with Firefox in Playwright 1.65, the second file chooser in a test sometimes opens the native picker instead of firing the event.
When the upstream issue is fixed and released, upgrade Playwright, remove the listener from nextFileChooser (keep the helper or go back to page.waitForEvent), and confirm with import.spec.js:428 repeated 40 times in Firefox with 8 workers.
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 3h 21m
- Merged PRs (30d)
- 250
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eizedev/pivotkit
-
accessibility area:react bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
area:cli bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
area:cli enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:react enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
documentation idea
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
All issues in eizedev/pivotkit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
embedpdf/embed-pdf-viewer#1116 ·
Maintainers usually reply within 1 day
-
[Docs]: Clarify theme variables location and usage in CONTRIBUTING.mdPossibly taken @srishtimishra520-beep claimed this today. Openkind/docs
Difficulty 1/5 Under an hour Newbie friendliness 88/100
meshery/meshery.io#3220 · 1 comment ·
Maintainers usually reply within 1 day
-
Module: Analytics P2 Team S Type: Infrastructure
Difficulty 1/5 Under an hour Newbie friendliness 90/100
google/site-kit-wp#14190 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
maathimself/mailflow#801 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day