cli: the NOT_ALLOWED hint always blames results: true

Open Beginner friendly
#562 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
83/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript
Domain
cli

Research direction

Read packages/pivotkit-cli/src/remote.js and locate problemError's handling of NOT_ALLOWED details. Check how it distinguishes refusals involving results, data, and sources, then add tests for the data and source cases. Done when the hint appears only for a results refusal and both other cases are covered by tests.

Written by the indexing model from the issue text.

Description

area:cli bug

In packages/pivotkit-cli/src/remote.js, problemError adds "this token's profile has no results: true" to every NOT_ALLOWED answer whose detail lacks "results: true". That also covers a data refusal (data: true) and a source refusal, where the hint is wrong. Add the hint only where the refusal is about results, and test the other two cases.

Dominant language
JavaScript
Stars
1
Forks
1
Avg merge
3h 21m
Merged PRs (30d)
250

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eizedev/pivotkit

All issues in eizedev/pivotkit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.