cli: the NOT_ALLOWED hint always blames results: true
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 83/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- cli
Research direction
Read packages/pivotkit-cli/src/remote.js and locate problemError's handling of NOT_ALLOWED details. Check how it distinguishes refusals involving results, data, and sources, then add tests for the data and source cases. Done when the hint appears only for a results refusal and both other cases are covered by tests.
Written by the indexing model from the issue text.
Description
In packages/pivotkit-cli/src/remote.js, problemError adds "this token's profile has no results: true" to every NOT_ALLOWED answer whose detail lacks "results: true". That also covers a data refusal (data: true) and a source refusal, where the hint is wrong. Add the hint only where the refusal is about results, and test the other two cases.
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 3h 21m
- Merged PRs (30d)
- 250
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eizedev/pivotkit
-
accessibility area:react bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
area:tests
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area:cli enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:react enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
documentation idea
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
All issues in eizedev/pivotkit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
embedpdf/embed-pdf-viewer#1116 ·
Maintainers usually reply within 1 day
-
[Docs]: Clarify theme variables location and usage in CONTRIBUTING.mdPossibly taken @srishtimishra520-beep claimed this today. Openkind/docs
Difficulty 1/5 Under an hour Newbie friendliness 88/100
meshery/meshery.io#3220 · 1 comment ·
Maintainers usually reply within 1 day
-
Module: Analytics P2 Team S Type: Infrastructure
Difficulty 1/5 Under an hour Newbie friendliness 90/100
google/site-kit-wp#14190 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
maathimself/mailflow#801 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day