Controlled report: a rejected change is not told apart from a late echo, the next step carries it
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- javascript, react
调研方向
Start with useViewHistory in packages/pivotkit-react/src/use-view-history.js and trace how echo.pending, waiting, and live handle views passed through onViewChange. Read the existing late-echo coverage for issue #141 and the cap work in #204, then review the host test page and reference/react.md and the element's events. Done means a host can explicitly reject a change, with tests and docs showing that the next change starts from the host's displayed view.
由索引模型根据 Issue 内容生成。
描述
A controlled report cannot tell a host that rejects a change from one that passes it back late, so after a rejected change the next step builds on the report's own history instead of the view the host shows.
Where: useViewHistory in use-view-history.js. While echo.pending holds views the host was told through onViewChange and has not passed back, waiting is true and live is the report's own history, not the view shown. A host that rejects a change keeps passing its old view, so the report keeps waiting.
Example: the host rejects "add Region". The user then adds Country. The report sends Region and Country with the second onViewChange; a host that accepts that one gets Region as well.
Not affected: hosts that pass every view back, early or late (#141), and uncontrolled reports. The list of waiting views no longer grows without end (capped in #204).
Why this needs a decision: the report sees the same view prop either way. A host that answers late re-renders with its old view in between (the test host does every 200 ms, with the same object), and hosts that build view anew on every render would give a new object each time, so neither the key nor the object identity tells a rejection apart. The host has to say it.
Proposal: a documented way to reject, for example onViewChange returning false (the view stays, nothing waits for it), or a host passing a new copy of its view after a change it rejects. The first is explicit and needs no guess about render timing; both need a host test page case and docs in reference/react.md and the element's events.
- 主要语言
- JavaScript
- 星标
- 1
- 派生
- 1
- 平均合并
- 3 小时 34 分钟
- 30 天内合并 PR
- 213
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
eizedev/pivotkit 的其他 Issue
-
area:server enhancement
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
area:server bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
area:server enhancement
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
documentation idea
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
area:tests idea
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
相似的 Issue
-
channels:edit check:passed
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
fix
难度 2/5 1-3 小时 新手友好度 68/100
idean3885/claude-ops-agent#1083 ·
维护者通常 1 天内回复
-
入群码过期未关闭
难度 1/5 1 小时以内 新手友好度 84/100
aliyun/ai-agent-handbook#29 · 1 条评论 ·
-
docs documentation need-triage SaaS
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
apache/cloudstack#14719 ·
维护者通常 1 天内回复