Controlled report: a rejected change is not told apart from a late echo, the next step carries it
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 35/100
- Issue-Typ
- Feature
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- javascript, react
- Bereich
- data-visualization, frontend
Rechercherichtung
Start with useViewHistory in packages/pivotkit-react/src/use-view-history.js and trace how echo.pending, waiting, and live handle views passed through onViewChange. Read the existing late-echo coverage for issue #141 and the cap work in #204, then review the host test page and reference/react.md and the element's events. Done means a host can explicitly reject a change, with tests and docs showing that the next change starts from the host's displayed view.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
A controlled report cannot tell a host that rejects a change from one that passes it back late, so after a rejected change the next step builds on the report's own history instead of the view the host shows.
Where: useViewHistory in use-view-history.js. While echo.pending holds views the host was told through onViewChange and has not passed back, waiting is true and live is the report's own history, not the view shown. A host that rejects a change keeps passing its old view, so the report keeps waiting.
Example: the host rejects "add Region". The user then adds Country. The report sends Region and Country with the second onViewChange; a host that accepts that one gets Region as well.
Not affected: hosts that pass every view back, early or late (#141), and uncontrolled reports. The list of waiting views no longer grows without end (capped in #204).
Why this needs a decision: the report sees the same view prop either way. A host that answers late re-renders with its old view in between (the test host does every 200 ms, with the same object), and hosts that build view anew on every render would give a new object each time, so neither the key nor the object identity tells a rejection apart. The host has to say it.
Proposal: a documented way to reject, for example onViewChange returning false (the view stays, nothing waits for it), or a host passing a new copy of its view after a change it rejects. The first is explicit and needs no guess about render timing; both need a host test page case and docs in reference/react.md and the element's events.
- Vorherrschende Sprache
- JavaScript
- Sterne
- 1
- Forks
- 1
- Ø Merge
- 3 Std. 21 Min.
- Gemergte PRs (30 T.)
- 250
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus eizedev/pivotkit
-
accessibility area:react bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
Maintainer antworten meist innerhalb von 1 Tag
-
area:tests
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
area:cli bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
Maintainer antworten meist innerhalb von 1 Tag
-
area:cli enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
area:react enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in eizedev/pivotkit
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
sfbrigade/pocket-gardens#60 ·
Maintainer antworten meist innerhalb von 5 Tagen
-
The print preview leaves writing space short by the margins of hidden headers, footers and solutionsOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
PreTeXtBook/pretext#3329 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
NativeScript/ios#577 ·
Maintainer antworten meist innerhalb von 1 Tag
-
could-have
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
-
01 type: bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 2 Tagen