A removed domain is released while its route still serves traffic

Offen
  • Stimmt etwas nicht?
#302 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
45/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
docker, typescript
Bereich
backend, devops

Rechercherichtung

Start with apps/api/src/modules/apps/infrastructure/prisma-application.store.ts and the syncDomains behavior described in the issue. Then trace how the deployment pipeline tracks active releases and route changes, since the fix must coordinate reservation release with route removal. Add a test for removing a domain without redeploying and attempting to claim it from another application; done means the claim is rejected while the route still exists or is switching.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

needs-decision

What

Removing a domain from an application's configuration deletes its reservation at once (syncDomains in apps/api/src/modules/apps/infrastructure/prisma-application.store.ts). The release that is still running keeps serving that domain through Caddy until the next successful deployment, and for longer if that deployment fails.

Meanwhile another application of the same organization can claim the domain. The reservation and the live route then name two different applications, and traffic can reach the wrong service.

Found by a security audit of the repository on 8 November 2026, still true on main. The audit reproduced the reassignment at the store level; the full behavior with Caddy has not been tested.

Design question

A reservation should last as long as something can serve the domain. Options:

  1. Keep the reservation while the active release, or a deployment in progress, still lists the domain; release it when the route is removed.
  2. Mark it as "releasing" and refuse new claims until the route is gone.

Both need the deployment pipeline to tell the apps module when a route was removed.

Done when

  • A domain cannot be claimed by another application while a route for it exists or is being switched.
  • A test covers: remove the domain, do not redeploy, try to claim it from another application.
Vorherrschende Sprache
TypeScript
Sterne
2
Forks
1
Ø Merge
7 Std. 17 Min.
Gemergte PRs (30 T.)
197

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus shipkeepdev/shipkeep

Alle Issues in shipkeepdev/shipkeep

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.