A removed domain is released while its route still serves traffic
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 45/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- docker, typescript
研究方向
Start with apps/api/src/modules/apps/infrastructure/prisma-application.store.ts and the syncDomains behavior described in the issue. Then trace how the deployment pipeline tracks active releases and route changes, since the fix must coordinate reservation release with route removal. Add a test for removing a domain without redeploying and attempting to claim it from another application; done means the claim is rejected while the route still exists or is switching.
由索引模型根據 Issue 內容生成。
描述
What
Removing a domain from an application's configuration deletes its reservation at once (syncDomains in apps/api/src/modules/apps/infrastructure/prisma-application.store.ts). The release that is still running keeps serving that domain through Caddy until the next successful deployment, and for longer if that deployment fails.
Meanwhile another application of the same organization can claim the domain. The reservation and the live route then name two different applications, and traffic can reach the wrong service.
Found by a security audit of the repository on 8 November 2026, still true on main. The audit reproduced the reassignment at the store level; the full behavior with Caddy has not been tested.
Design question
A reservation should last as long as something can serve the domain. Options:
- Keep the reservation while the active release, or a deployment in progress, still lists the domain; release it when the route is removed.
- Mark it as "releasing" and refuse new claims until the route is gone.
Both need the deployment pipeline to tell the apps module when a route was removed.
Done when
- A domain cannot be claimed by another application while a route for it exists or is being switched.
- A test covers: remove the domain, do not redeploy, try to claim it from another application.
- 主要語言
- TypeScript
- 星號
- 2
- 分支
- 1
- 平均合併
- 7 小時 17 分鐘
- 30 天內合併 PR
- 197
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
shipkeepdev/shipkeep 的其他 Issue
-
good first issue
難度 2/5 1-3 小時 新手友好度 84/100
shipkeepdev/shipkeep#295 ·
維護者通常 1 天內回覆
-
good first issue priority:P2 track:control-plane
難度 2/5 1-3 小時 新手友好度 78/100
shipkeepdev/shipkeep#212 ·
維護者通常 1 天內回覆
-
enhancement good first issue priority:P3 track:web
難度 2/5 1-3 小時 新手友好度 85/100
shipkeepdev/shipkeep#144 ·
維護者通常 1 天內回覆
-
documentation good first issue priority:P3 track:control-plane
難度 2/5 1-3 小時 新手友好度 78/100
shipkeepdev/shipkeep#143 ·
維護者通常 1 天內回覆
-
enhancement good first issue priority:P3 track:control-plane
難度 2/5 1-3 小時 新手友好度 85/100
shipkeepdev/shipkeep#142 ·
維護者通常 1 天內回覆
查看 shipkeepdev/shipkeep 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
vercel-labs/ui#540 ·
維護者通常 1 天內回覆
-
accepted ai-dev ai-implementing
難度 2/5 1-3 小時 新手友好度 74/100
維護者通常 1 天內回覆
-
normalizePropName strips `#` characters from Figma property names instead of only the `#id` suffix未關閉
難度 2/5 1-3 小時 新手友好度 72/100
figma/code-connect#419 ·
-
難度 2/5 1-3 小時 新手友好度 78/100
-
Negative values skip k/M abbreviation and medium decimal format on line, stacked-area, and tooltip未關閉
難度 2/5 1-3 小時 新手友好度 84/100
britecharts/britecharts#1255 ·
維護者通常 1 天內回覆