A removed domain is released while its route still serves traffic

Abierto
  • ¿Algo no está bien?
#302 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
docker, typescript
Área
backend, devops

Línea de trabajo

Start with apps/api/src/modules/apps/infrastructure/prisma-application.store.ts and the syncDomains behavior described in the issue. Then trace how the deployment pipeline tracks active releases and route changes, since the fix must coordinate reservation release with route removal. Add a test for removing a domain without redeploying and attempting to claim it from another application; done means the claim is rejected while the route still exists or is switching.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

needs-decision

What

Removing a domain from an application's configuration deletes its reservation at once (syncDomains in apps/api/src/modules/apps/infrastructure/prisma-application.store.ts). The release that is still running keeps serving that domain through Caddy until the next successful deployment, and for longer if that deployment fails.

Meanwhile another application of the same organization can claim the domain. The reservation and the live route then name two different applications, and traffic can reach the wrong service.

Found by a security audit of the repository on 8 November 2026, still true on main. The audit reproduced the reassignment at the store level; the full behavior with Caddy has not been tested.

Design question

A reservation should last as long as something can serve the domain. Options:

  1. Keep the reservation while the active release, or a deployment in progress, still lists the domain; release it when the route is removed.
  2. Mark it as "releasing" and refuse new claims until the route is gone.

Both need the deployment pipeline to tell the apps module when a route was removed.

Done when

  • A domain cannot be claimed by another application while a route for it exists or is being switched.
  • A test covers: remove the domain, do not redeploy, try to claim it from another application.
Lenguaje dominante
TypeScript
Estrellas
2
Forks
1
Merge medio
7 h 17 min
PR fusionados (30 d)
197

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de shipkeepdev/shipkeep

Todos los issues de shipkeepdev/shipkeep

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.