A removed domain is released while its route still serves traffic

Ouverte
  • Quelque chose ne va pas ?
#302 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
45/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
docker, typescript
Domaine
backend, devops

Piste de recherche

Start with apps/api/src/modules/apps/infrastructure/prisma-application.store.ts and the syncDomains behavior described in the issue. Then trace how the deployment pipeline tracks active releases and route changes, since the fix must coordinate reservation release with route removal. Add a test for removing a domain without redeploying and attempting to claim it from another application; done means the claim is rejected while the route still exists or is switching.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

needs-decision

What

Removing a domain from an application's configuration deletes its reservation at once (syncDomains in apps/api/src/modules/apps/infrastructure/prisma-application.store.ts). The release that is still running keeps serving that domain through Caddy until the next successful deployment, and for longer if that deployment fails.

Meanwhile another application of the same organization can claim the domain. The reservation and the live route then name two different applications, and traffic can reach the wrong service.

Found by a security audit of the repository on 8 November 2026, still true on main. The audit reproduced the reassignment at the store level; the full behavior with Caddy has not been tested.

Design question

A reservation should last as long as something can serve the domain. Options:

  1. Keep the reservation while the active release, or a deployment in progress, still lists the domain; release it when the route is removed.
  2. Mark it as "releasing" and refuse new claims until the route is gone.

Both need the deployment pipeline to tell the apps module when a route was removed.

Done when

  • A domain cannot be claimed by another application while a route for it exists or is being switched.
  • A test covers: remove the domain, do not redeploy, try to claim it from another application.
Langage dominant
TypeScript
Étoiles
2
Forks
1
Merge moyen
7 h 17 min
PR mergées (30 j)
197

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de shipkeepdev/shipkeep

Toutes les issues de shipkeepdev/shipkeep

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.