0.6.6: follow-ups from the Model K softmax self-check review (#254)
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Anfängerfreundlichkeit
- 35/100
- Issue-Typ
- Bug
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- cpp
- Bereich
- backend, performance
Rechercherichtung
Start by reading the review follow-ups in this issue and the implementation and tests for the create-time self-check introduced in #254. Trace preparation, embedded manifest and shader loading, digest generation, and the game-path executor's runtime creation. Done means the five listed gaps are addressed, with negative controls and boundary shapes tested and end-to-end creation measured on supported devices.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Follow-ups from the review rounds of #254 (Model K softmax weight rounding in one mixed-precision FMA, with a create-time self-check). None of them changes the output of a frame that passes the self-check. They are tracked here for 0.6.6.
1. Shape coverage beyond the sampled sizes
The self-check runs each selectable softmax stage at the window offsets the frames use, but only at sampled output sizes (for example, the m stage only at one large base). A defect that depends on the map size, such as a small m map or partial windows at an edge, could pass the check. Add shape-dependent negative controls, and cover boundary and partial-window shapes, or verify the compiled data flow independently of the sampled sizes.
2. Preparation that silently skips a port
The create-time preparation step returns success for a manifest entry whose variant does not match or whose root signature is unsupported, while the launch path later refuses the same entry. Such an entry, even with a corrupt shader, then passes create and fails on the first frame. Make preparation fail on these cases, and test them.
3. Stale embedded manifest and shader pairs
The manifest and each shader fall back to the embedded copies independently. A runtime built from a reused output folder could embed an old, matching pair, which then passes the integrity check when the loose files are absent. The fixed-weight stages are not in the output-hash self-check. Bind the embedded artifacts to the intended build's sources (the new per-entry source digests are a start), and refuse stale ones before embedding.
4. Self-check digest inputs and reference provenance
The digest that binds the reference header to its sources does not yet include the stage table and layout helpers, the FP16 conversion used to make the synthetic inputs, or the separately compiled probe. The header generator also stamps the current digest onto a reference build without checking that build's own provenance. Include those inputs, and verify the reference build before stamping.
5. Create time
Native create with the self-check takes about 1.7 s at 1440p Quality, and the game-path executor creates the runtime twice. Reduce the duplicate check (for example, reuse a verified result safely within one process), and measure end-to-end creation on supported devices.
- Vorherrschende Sprache
- C++
- Sterne
- 12
- Forks
- 2
- Ø Merge
- 3 Std. 10 Min.
- Gemergte PRs (30 T.)
- 171
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus phantoslayer21/wronggpu
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
phantoslayer21/wronggpu#275 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
phantoslayer21/wronggpu#274 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
phantoslayer21/wronggpu#241 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug build
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
phantoslayer21/wronggpu#234 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug build
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
phantoslayer21/wronggpu#233 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in phantoslayer21/wronggpu
Ähnliche Issues
-
ai_p2
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
ClickHouse/ClickHouse#132519 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeOffen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
juce-framework/JUCE#1810 ·
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 82/100
petercorke/robotics-toolbox-python#952 ·
Maintainer antworten meist innerhalb von 1 Tag
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusOffenfunc:engine type:bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
NatronGitHub/Natron#1276 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 77/100
Maintainer antworten meist innerhalb von 1 Tag